Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: chrome/browser/ui/cocoa/device_chooser_content_view_cocoa.mm

Issue 2595083002: Change ChooserContentView[Cocoa] class name to be DeviceChooserContentView[Cocoa] (Closed)
Patch Set: merge master Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/device_chooser_content_view_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm b/chrome/browser/ui/cocoa/device_chooser_content_view_cocoa.mm
similarity index 98%
rename from chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm
rename to chrome/browser/ui/cocoa/device_chooser_content_view_cocoa.mm
index 0c3db026114da7ae62d49effe144019d99f5c776..3c150148d14b35208ccb5e3998517ff396c9741b 100644
--- a/chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm
+++ b/chrome/browser/ui/cocoa/device_chooser_content_view_cocoa.mm
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#import "chrome/browser/ui/cocoa/chooser_content_view_cocoa.h"
+#import "chrome/browser/ui/cocoa/device_chooser_content_view_cocoa.h"
#include <algorithm>
@@ -389,12 +389,8 @@ void ChooserContentViewController::UpdateTableView() {
[table_view_ selectRowIndexes:selected_rows byExtendingSelection:NO];
}
-@implementation ChooserContentViewCocoa
+@implementation DeviceChooserContentViewCocoa
-// TODO(juncai): restructure this function to be some smaller methods to
-// create the pieces for the view. By doing so, the methods that calculate
-// the frame and origins can be moved into those methods, rather than as
-// helper functions.
- (instancetype)initWithChooserTitle:(NSString*)chooserTitle
chooserController:
(std::unique_ptr<ChooserController>)chooserController {

Powered by Google App Engine
This is Rietveld 408576698