Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2595073002: Convert audiobuffer.html to testharness (Closed)

Created:
4 years ago by Raymond Toy
Modified:
3 years, 11 months ago
Reviewers:
hongchan
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert audiobuffer.html to testharness Manually convert audiobuffer.html to use testharness BUG=676355 TEST=audiobuffer.html Committed: https://crrev.com/49fe1c6f7e1960a24ed71a67e69de71371bf7ed5 Cr-Commit-Position: refs/heads/master@{#441477}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Remove unneeded expected results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -71 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer.html View 1 1 chunk +56 lines, -52 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer-expected.txt View 1 2 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Raymond Toy
PTAL
3 years, 11 months ago (2017-01-04 19:15:15 UTC) #11
hongchan
lgtm
3 years, 11 months ago (2017-01-04 21:45:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595073002/40001
3 years, 11 months ago (2017-01-04 21:47:01 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2017-01-04 21:53:44 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 21:56:32 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/49fe1c6f7e1960a24ed71a67e69de71371bf7ed5
Cr-Commit-Position: refs/heads/master@{#441477}

Powered by Google App Engine
This is Rietveld 408576698