Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer.html

Issue 2595073002: Convert audiobuffer.html to testharness (Closed)
Patch Set: Remove unneeded expected results Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer.html b/third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer.html
index 65abaa168d1347fba5235d70021302997c4eac2f..0f23cff2a2031e14fe41a6767eb4b151b65a2af6 100644
--- a/third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer.html
+++ b/third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer.html
@@ -1,62 +1,66 @@
<!DOCTYPE html>
<html>
<head>
-<script src="../../resources/js-test.js"></script>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
<script src="../resources/audit-util.js"></script>
-<script src="../resources/audio-testing.js"></script>
+<script src="../resources/audit.js"></script>
</head>
<body>
<script>
-description("Basic tests for AudioBuffer.");
-
-var sampleRate = 44100.0
-var lengthInSeconds = 2;
-var numberOfChannels = 4;
-
-var context = new AudioContext();
-var buffer = context.createBuffer(numberOfChannels, sampleRate * lengthInSeconds, sampleRate);
-
-if (buffer.sampleRate === sampleRate)
- testPassed("sampleRate has been set correctly.");
-else
- testFailed("sampleRate should be set correctly.");
-
-if (buffer.length === sampleRate * lengthInSeconds)
- testPassed("length has been set correctly.");
-else
- testFailed("length should be set correctly");
-
-if (buffer.duration === lengthInSeconds)
- testPassed("duration has been set correctly.");
-else
- testFailed("duration should be set correctly.");
-
-if (buffer.numberOfChannels === numberOfChannels)
- testPassed("numberOfChannels has been set correctly.");
-else
- testFailed("numberOfChannels should be set correctly.");
-
-for (var index = 0; index < buffer.numberOfChannels; ++index) {
- if (buffer.getChannelData(index) instanceof window.Float32Array)
- testPassed("getChannelData(" + index + ") returns a Float32Array object.");
- else
- testFailed("getChannelData(" + index + ") should return a Float32Array object.");
-}
-
-try {
- buffer.getChannelData(buffer.numberOfChannels);
- testFailed("Exception should be thrown when index is not less than numberOfChannels.");
-} catch(e) {
- testPassed("Exception has been thrown correctly when index is not less than numberOfChannels.");
-}
-
-var buffer2 = context.createBuffer(1, 1000, 24576);
-var expectedDuration = 1000/24576;
-
-if (buffer2.duration == expectedDuration)
- testPassed("duration has expected accuracy.");
-else
- testFailed("duration is " + buffer2.duration + " sec instead of " + expectedDuration + " sec.");
+let sampleRate = 44100.0
+let lengthInSeconds = 2;
+let numberOfChannels = 4;
+
+let audit = Audit.createTaskRunner();
+
+audit.define("Basic tests for AudioBuffer", function (task, should) {
+ let context = new AudioContext();
+ let buffer = context.createBuffer(numberOfChannels,
+ sampleRate * lengthInSeconds, sampleRate);
+
+ // Just for printing out a message describing what "buffer" is in the
+ // following tests.
+ should(true,
+ "buffer = context.createBuffer(" + numberOfChannels + ", " + (
+ sampleRate * lengthInSeconds) + ", " + sampleRate + ")")
+ .beTrue();
+
+ should(buffer.sampleRate, "buffer.sampleRate")
+ .beEqualTo(sampleRate);
+
+ should(buffer.length, "buffer.length")
+ .beEqualTo(sampleRate * lengthInSeconds);
+
+ should(buffer.duration, "buffer.duration")
+ .beEqualTo(lengthInSeconds);
+
+ should(buffer.numberOfChannels, "buffer.numberOfChannels")
+ .beEqualTo(numberOfChannels);
+
+ for (let index = 0; index < buffer.numberOfChannels; ++index) {
+ should(
+ buffer.getChannelData(index) instanceof window.Float32Array,
+ "buffer.getChannelData(" + index +
+ ") instanceof window.Float32Array")
+ .beTrue();
+ }
+
+ should(function () {
+ buffer.getChannelData(buffer.numberOfChannels);
+ }, "buffer.getChannelData(" + buffer.numberOfChannels + ")")
+ .throw("IndexSizeError");
+
+ let buffer2 = context.createBuffer(1, 1000, 24576);
+ let expectedDuration = 1000 / 24576;
+
+ should(buffer2.duration, "context.createBuffer(1, 1000, 24576).duration")
+ .beEqualTo(expectedDuration);
+
+ task.done();
+});
+
+audit.run();
</script>
</body>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/AudioBuffer/audiobuffer-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698