Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2594993002: [wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* (Closed)

Created:
4 years ago by titzer
Modified:
4 years ago
Reviewers:
Clemens Hammacher
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* This is more renaming work to comply with the naming in the public design repository. E.g. types are called "value types" and we no longer refer to ASTs. R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594993002 Cr-Commit-Position: refs/heads/master@{#41891} Committed: https://chromium.googlesource.com/v8/v8/+/55fc5c0c327cec8385503bdcda0cfcee7f51213e

Patch Set 1 #

Patch Set 2 : [wasm] Rename wasm::LocalType to wasm::ValueType and kAst* to kWasm* #

Patch Set 3 : Fix inspector tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+889 lines, -888 lines) Patch
M src/asmjs/asm-wasm-builder.cc View 35 chunks +80 lines, -80 lines 0 comments Download
M src/compiler/wasm-compiler.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 14 chunks +32 lines, -33 lines 0 comments Download
M src/compiler/wasm-linkage.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M src/wasm/function-body-decoder.h View 6 chunks +19 lines, -19 lines 0 comments Download
M src/wasm/function-body-decoder.cc View 1 27 chunks +88 lines, -88 lines 0 comments Download
M src/wasm/module-decoder.cc View 12 chunks +31 lines, -31 lines 0 comments Download
M src/wasm/wasm-interpreter.h View 2 chunks +9 lines, -9 lines 0 comments Download
M src/wasm/wasm-interpreter.cc View 6 chunks +22 lines, -22 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 6 chunks +10 lines, -10 lines 0 comments Download
M src/wasm/wasm-module.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/wasm/wasm-module.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M src/wasm/wasm-module-builder.h View 4 chunks +8 lines, -8 lines 0 comments Download
M src/wasm/wasm-module-builder.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 8 chunks +93 lines, -93 lines 0 comments Download
M src/wasm/wasm-opcodes.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 17 chunks +26 lines, -26 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-js.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 7 chunks +16 lines, -16 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 11 chunks +20 lines, -20 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd-lowering.cc View 10 chunks +16 lines, -16 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 5 chunks +8 lines, -8 lines 0 comments Download
M test/common/wasm/test-signatures.h View 4 chunks +24 lines, -24 lines 0 comments Download
M test/fuzzer/wasm-call.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M test/inspector/debugger/wasm-scripts.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/inspector/debugger/wasm-source.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/inspector/debugger/wasm-stack.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/adapter-frame.js View 19 chunks +21 lines, -21 lines 0 comments Download
M test/mjsunit/wasm/compiled-module-serialization.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/data-segments.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/errors.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/mjsunit/wasm/exceptions.js View 10 chunks +14 lines, -14 lines 0 comments Download
M test/mjsunit/wasm/ffi.js View 3 chunks +11 lines, -11 lines 0 comments Download
M test/mjsunit/wasm/gc-frame.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/globals.js View 3 chunks +17 lines, -17 lines 0 comments Download
M test/mjsunit/wasm/import-table.js View 3 chunks +11 lines, -11 lines 0 comments Download
M test/mjsunit/wasm/indirect-calls.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/indirect-tables.js View 4 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/wasm/instantiate-module-basic.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/module-memory.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/params.js View 6 chunks +10 lines, -10 lines 0 comments Download
M test/mjsunit/wasm/test-wasm-module-builder.js View 3 chunks +6 lines, -6 lines 0 comments Download
M test/mjsunit/wasm/trap-location.js View 2 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/trap-location-with-trap-if.js View 2 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 2 chunks +26 lines, -26 lines 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 3 chunks +8 lines, -8 lines 0 comments Download
M test/unittests/wasm/function-body-decoder-unittest.cc View 46 chunks +141 lines, -139 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 8 chunks +22 lines, -22 lines 0 comments Download
M test/unittests/wasm/wasm-module-builder-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (16 generated)
titzer
4 years ago (2016-12-21 12:05:16 UTC) #1
Clemens Hammacher
lgtm
4 years ago (2016-12-21 12:34:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594993002/40001
4 years ago (2016-12-21 13:40:58 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-21 13:43:06 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/55fc5c0c327cec8385503bdcda0cfcee7f5...

Powered by Google App Engine
This is Rietveld 408576698