Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2594973003: [wasm] Rename ast-decoder.* to function-body-decoder.* (Closed)

Created:
4 years ago by titzer
Modified:
4 years ago
Reviewers:
Clemens Hammacher
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Rename ast-decoder.* to function-body-decoder.* Since WASM is no longer an AST :-( R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2594973003 Cr-Commit-Position: refs/heads/master@{#41889} Committed: https://chromium.googlesource.com/v8/v8/+/ceb29f7c62d3e5e19fa8ba54b543fed71e944112

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -5552 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/v8.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
D src/wasm/ast-decoder.h View 1 chunk +0 lines, -479 lines 0 comments Download
D src/wasm/ast-decoder.cc View 1 chunk +0 lines, -2068 lines 0 comments Download
A + src/wasm/function-body-decoder.h View 6 chunks +12 lines, -12 lines 1 comment Download
A + src/wasm/function-body-decoder.cc View 9 chunks +16 lines, -16 lines 0 comments Download
M src/wasm/module-decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-interpreter.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-module-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-opcodes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-text.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -1 line 0 comments Download
D test/unittests/wasm/ast-decoder-unittest.cc View 1 chunk +0 lines, -2740 lines 0 comments Download
A + test/unittests/wasm/function-body-decoder-unittest.cc View 111 chunks +217 lines, -215 lines 0 comments Download
M test/unittests/wasm/loop-assignment-analysis-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/wasm/wasm-module-builder-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 2594993002 Patch 1
Issue 2594993002 Patch 20001
Issue 2594993002 Patch 40001

Messages

Total messages: 11 (7 generated)
titzer
4 years ago (2016-12-21 10:47:45 UTC) #1
Clemens Hammacher
lgtm https://codereview.chromium.org/2594973003/diff/1/src/wasm/function-body-decoder.h File src/wasm/function-body-decoder.h (right): https://codereview.chromium.org/2594973003/diff/1/src/wasm/function-body-decoder.h#newcode341 src/wasm/function-body-decoder.h:341: std::vector<std::tuple<uint32_t, int, int>>* offset_table); At some point I ...
4 years ago (2016-12-21 12:32:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594973003/1
4 years ago (2016-12-21 12:40:26 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-21 12:42:11 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ceb29f7c62d3e5e19fa8ba54b543fed71e9...

Powered by Google App Engine
This is Rietveld 408576698