Enable no-compile tests on linux clang

Enable no-compile tests on linux clang

BUG=105388
Committed: https://crrev.com/7a9a5838fe86ec2de95e61adb4cabe959663b8b2
Cr-Commit-Position: refs/heads/master@{#440384}

[wychen, 2016-12-21 07:49:32]

wychen@chromium.org changed reviewers:
+ dcheng@chromium.org, jbudorick@chromium.org, thakis@chromium.org

[wychen, 2016-12-21 07:49:33]

https://codereview.chromium.org/2504383002/ passed CQ but failed on Mac. Let's
limit it to linux only and give it another shot.

[wychen, 2016-12-21 07:50:23]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 07:50:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-12-21 07:50:46]

lgtm

[commit-bot: I haz the power, 2016-12-21 08:56:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 08:56:14]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-12-21 14:40:46]

LGTM; is there a bug for the failure on Mac? Linux is fairly similar to it...

[wychen, 2016-12-22 10:33:42]

On 2016/12/21 14:40:46, Nico (swamped sorry) wrote:
> LGTM; is there a bug for the failure on Mac? Linux is fairly similar to it...

One of the errors from
https://build.chromium.org/p/chromium/builders/Mac/builds/22001/steps/compile...
is:

python ../../tools/nocompile_driver.py 4 ../../base/callback_list_unittest.nc
-Wall\ -Werror\ -Wfatal-errors\ -I../../ gen/base/callback_list_unittest_nc.cc
In file included from ../../base/callback_list_unittest.nc:8:
In file included from ../../base/callback_list.h:8:
In file included from
/b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/list:173:
In file included from
/b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/memory:629:
In file included from
/b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/typeinfo:61:
In file included from
/b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/exception:82:
In file included from
/b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/cstdlib:86:
/b/c/b/mac_ng/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/stdlib.h:94:15:
fatal error: 'stdlib.h' file not found
#include_next <stdlib.h>
              ^~~~~~~~~~
1 error generated.

[wychen, 2016-12-22 10:33:48]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2016-12-22 10:34:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 11:29:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482402828903980, "parent_rev":
"a82a1c783ba20b89ce3600d41d97e96ba3412d30", "commit_rev":
"9317d6d93fdd593fdd198968b3b261d8cfd79e81"}

[commit-bot: I haz the power, 2016-12-22 11:30:11]

Description was changed from

==========
Enable no-compile tests on linux clang

BUG=105388
==========

to

==========
Enable no-compile tests on linux clang

BUG=105388

Review-Url: https://codereview.chromium.org/2594943002
==========

[commit-bot: I haz the power, 2016-12-22 11:30:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-22 11:33:56]

Description was changed from

==========
Enable no-compile tests on linux clang

BUG=105388

Review-Url: https://codereview.chromium.org/2594943002
==========

to

==========
Enable no-compile tests on linux clang

BUG=105388

Committed: https://crrev.com/7a9a5838fe86ec2de95e61adb4cabe959663b8b2
Cr-Commit-Position: refs/heads/master@{#440384}
==========

[commit-bot: I haz the power, 2016-12-22 11:33:57]

Patchset 1 (id:??) landed as
https://crrev.com/7a9a5838fe86ec2de95e61adb4cabe959663b8b2
Cr-Commit-Position: refs/heads/master@{#440384}

[Ossy, 2016-12-22 13:58:01]

On 2016/12/22 11:33:57, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/7a9a5838fe86ec2de95e61adb4cabe959663b8b2
> Cr-Commit-Position: refs/heads/master@{#440384}

It broke the build on Linux. Could you check what happened?

FAILED: obj/base/base_nocompile_tests/bind_unittest_nc.o
../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/base/base_nocompile_tests/bind_unittest_nc.o.d -DV8_DEPRECATION_WARNINGS
-DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1
-DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING
-DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD
-DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED
-DCR_CLANG_REVISION=289944-2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
-DCOMPONENT_BUILD -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1
-DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_GLIBCXX_DEBUG=1 -DGTEST_HAS_POSIX_RE=0
-DGTEST_LANG_CXX11=1 -DUNIT_TEST -I.. -Igen
-I../build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0
-I../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include
-I../testing/gtest/include -fno-strict-aliasing --param=ssp-buffer-size=4
-fstack-protector -funwind-tables -fPIC -pipe
-B../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics
-fdebug-prefix-map=/home/oszi/chromium/src=. -m64 -march=x86-64 -pthread -Wall
-Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter
-Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-undefined-var-template
-Wno-nonportable-include-path -Wno-address-of-packed-member -O0
-fno-omit-frame-pointer -g2 -gsplit-dwarf
--sysroot=../build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden -Xclang
-load -Xclang
../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang
-add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs
-Xclang check-ipc -Wheader-hygiene -Wstring-conversion
-Wtautological-overlap-compare -fno-threadsafe-statics
-fvisibility-inlines-hidden -Wno-undefined-bool-conversion
-Wno-tautological-undefined-compare -std=gnu++11 -fno-rtti -fno-exceptions -c
gen/base/bind_unittest_nc.cc -o obj/base/base_nocompile_tests/bind_unittest_nc.o
gen/base/bind_unittest_nc.cc:50:2: error: "NCTEST_DISALLOW_CAPTURING_LAMBDA
Failed: Expectations [r'fatal error: implicit instantiation of undefined
template 'base::internal::FunctorTraits<\(lambda at
../../base/bind_unittest.nc:[0-9]+:[0-9]+\), void>''] did not match output."
#error "NCTEST_DISALLOW_CAPTURING_LAMBDA Failed: Expectations [r'fatal error:
implicit instantiation of undefined template
'base::internal::FunctorTraits<\(lambda at
../../base/bind_unittest.nc:[0-9]+:[0-9]+\), void>''] did not match output."
 ^
gen/base/bind_unittest_nc.cc:51:2: error: "compile line:
/home/oszi/chromium/src/tools/../third_party/llvm-build/Release+Asserts/bin/clang++
-Wall -Werror -Wfatal-errors -I../ -DNCTEST_DISALLOW_CAPTURING_LAMBDA -std=c++11
-o /dev/null -c -x c++ ../base/bind_unittest.nc"
#error "compile line:
/home/oszi/chromium/src/tools/../third_party/llvm-build/Release+Asserts/bin/clang++
-Wall -Werror -Wfatal-errors -I../ -DNCTEST_DISALLOW_CAPTURING_LAMBDA -std=c++11
-o /dev/null -c -x c++ ../base/bind_unittest.nc"
 ^
gen/base/bind_unittest_nc.cc:52:2: error: "NCTEST_DISALLOW_CAPTURING_LAMBDA
stderr:"
#error "NCTEST_DISALLOW_CAPTURING_LAMBDA stderr:"
 ^
gen/base/bind_unittest_nc.cc:53:2: error: "  In file included from
../base/bind_unittest.nc:10:"
#error "  In file included from ../base/bind_unittest.nc:10:"
 ^
gen/base/bind_unittest_nc.cc:54:2: error: "  In file included from
../base/bind.h:8:"
#error "  In file included from ../base/bind.h:8:"
 ^
gen/base/bind_unittest_nc.cc:55:2: error: "  ../base/bind_internal.h:372:16:
fatal error: implicit instantiation of undefined template
'base::internal::FunctorTraits<(lambda at ../base/bind_unittest.nc:210:8),
void>'"
#error "  ../base/bind_internal.h:372:16: fatal error: implicit instantiation of
undefined template 'base::internal::FunctorTraits<(lambda at
../base/bind_unittest.nc:210:8), void>'"
 ^
gen/base/bind_unittest_nc.cc:56:2: error: "        typename
FunctorTraits<typename std::decay<Functor>::type>::RunType;"
#error "        typename FunctorTraits<typename
std::decay<Functor>::type>::RunType;"
 ^
gen/base/bind_unittest_nc.cc:57:2: error: "                 ^"
#error "                 ^"
 ^
gen/base/bind_unittest_nc.cc:58:2: error: "  ../base/bind_internal.h:538:1:
note: in instantiation of template class
'base::internal::MakeUnboundRunTypeImpl<(lambda at
../base/bind_unittest.nc:210:8)>' requested here"
#error "  ../base/bind_internal.h:538:1: note: in instantiation of template
class 'base::internal::MakeUnboundRunTypeImpl<(lambda at
../base/bind_unittest.nc:210:8)>' requested here"
 ^
gen/base/bind_unittest_nc.cc:59:2: error: "  using MakeUnboundRunType ="
#error "  using MakeUnboundRunType ="
 ^
gen/base/bind_unittest_nc.cc:60:2: error: "  ^"
#error "  ^"
 ^
gen/base/bind_unittest_nc.cc:61:2: error: "  ../base/bind.h:75:17: note: in
instantiation of template type alias 'MakeUnboundRunType' requested here"
#error "  ../base/bind.h:75:17: note: in instantiation of template type alias
'MakeUnboundRunType' requested here"
 ^
gen/base/bind_unittest_nc.cc:62:2: error: "  inline
Callback<MakeUnboundRunType<Functor, Args...>>"
#error "  inline Callback<MakeUnboundRunType<Functor, Args...>>"
 ^
gen/base/bind_unittest_nc.cc:63:2: error: "                  ^"
#error "                  ^"
 ^
gen/base/bind_unittest_nc.cc:64:2: error: "  ../base/bind_unittest.nc:210:3:
note: while substituting deduced template arguments into function template
'Bind' [with Functor = (lambda at ../base/bind_unittest.nc:210:8), Args = <>]"
#error "  ../base/bind_unittest.nc:210:3: note: while substituting deduced
template arguments into function template 'Bind' [with Functor = (lambda at
../base/bind_unittest.nc:210:8), Args = <>]"
 ^
gen/base/bind_unittest_nc.cc:65:2: error: "    Bind([i]() {});"
#error "    Bind([i]() {});"
 ^
gen/base/bind_unittest_nc.cc:66:2: error: "    ^"
#error "    ^"
 ^
gen/base/bind_unittest_nc.cc:67:2: error: "  ../base/bind_internal.h:134:8:
note: template is declared here"
#error "  ../base/bind_internal.h:134:8: note: template is declared here"
 ^
gen/base/bind_unittest_nc.cc:68:2: error: "  struct FunctorTraits;"
#error "  struct FunctorTraits;"
 ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
ninja: build stopped: subcommand failed.

[Ossy, 2016-12-22 15:24:51]

I reported the build failure:
https://bugs.chromium.org/p/chromium/issues/detail?id=676649

[Nico, 2016-12-22 16:34:21]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2593333004/ by thakis@chromium.org.

The reason for reverting is: Doesn't build everywhere, see
https://crbug.com/676649.

[wychen, 2016-12-23 04:22:08]

Reincarnated here:
https://codereview.chromium.org/2599243002/

It can be relanded after the fix here:
https://codereview.chromium.org/2600443003/