Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3054)

Unified Diff: content/shell/renderer/layout_test/layout_test_render_frame_observer.h

Issue 2594913002: Replace IPC messages in layout_test_render_frame_observer. (Closed)
Patch Set: Removed a redundant line Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/layout_test/layout_test_render_frame_observer.h
diff --git a/content/shell/renderer/layout_test/layout_test_render_frame_observer.h b/content/shell/renderer/layout_test/layout_test_render_frame_observer.h
index 230ec1cee57d7035647add822493429ba11d1b63..bd620c082d42431e67177865c73bf57bca87940b 100644
--- a/content/shell/renderer/layout_test/layout_test_render_frame_observer.h
+++ b/content/shell/renderer/layout_test/layout_test_render_frame_observer.h
@@ -7,33 +7,29 @@
#include "base/macros.h"
#include "content/public/renderer/render_frame_observer.h"
-
-namespace IPC {
-class Message;
-} // namespace IPC
+#include "content/shell/common/layout_test.mojom.h"
+#include "mojo/public/cpp/bindings/associated_binding.h"
namespace content {
-struct ShellTestConfiguration;
-class RenderFrame;
-struct ShellTestConfiguration;
-class LayoutTestRenderFrameObserver : public RenderFrameObserver {
+class LayoutTestRenderFrameObserver : public RenderFrameObserver,
+ public mojom::LayoutTestControl {
public:
explicit LayoutTestRenderFrameObserver(RenderFrame* render_frame);
- ~LayoutTestRenderFrameObserver() override {}
-
- // RenderFrameObserver implementation.
- bool OnMessageReceived(const IPC::Message& message) override;
+ ~LayoutTestRenderFrameObserver() override;
private:
// RenderFrameObserver implementation.
void OnDestruct() override;
- void OnLayoutDumpRequest();
- void OnSetTestConfiguration(const ShellTestConfiguration& test_config);
- void OnReplicateTestConfiguration(const ShellTestConfiguration& test_config);
- void OnSetupSecondaryRenderer();
+ void LayoutDumpRequest() override;
+ void SetTestConfiguration(mojom::ShellTestConfigurationPtr config) override;
+ void ReplicateTestConfiguration(
+ mojom::ShellTestConfigurationPtr config) override;
+ void SetupSecondaryRenderer() override;
+ void BindRequest(mojom::LayoutTestControlAssociatedRequest request);
+ mojo::AssociatedBinding<mojom::LayoutTestControl> binding_;
DISALLOW_COPY_AND_ASSIGN(LayoutTestRenderFrameObserver);
};

Powered by Google App Engine
This is Rietveld 408576698