Revert 'Bypass UIWebView.scrollView's contentInset implementation with UIScrollView's.

Revert 'Bypass UIWebView.scrollView's contentInset implementation with UIScrollView's.

We had already stopped using this in full screen controller when we moved to
WKWebView, but pull-to-action and some cruft remained.

BUG=675746
Committed: https://crrev.com/04c2777134dd67f93da8d059c973521e18e8e55b
Cr-Commit-Position: refs/heads/master@{#440198}

[justincohen, 2016-12-21 18:00:17]

The CQ bit was checked by justincohen@chromium.org to run a CQ dry run

[justincohen, 2016-12-21 18:00:29]

justincohen@chromium.org changed reviewers:
+ eugenebut@chromium.org

[justincohen, 2016-12-21 18:00:30]

ptal

[commit-bot: I haz the power, 2016-12-21 18:00:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 18:11:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 18:11:28]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2016-12-21 18:48:43]

Thank you for cleanup. I think OverscrollActionsController changes will break
stuff, but FullscreenController changes are correct.

https://codereview.chromium.org/2594793004/diff/1/ios/chrome/browser/ui/fulls...
File ios/chrome/browser/ui/fullscreen_controller.h (right):

https://codereview.chromium.org/2594793004/diff/1/ios/chrome/browser/ui/fulls...
ios/chrome/browser/ui/fullscreen_controller.h:109: // Update the insets during
animation.
s/Update/Updates

https://codereview.chromium.org/2594793004/diff/1/ios/chrome/browser/ui/overs...
File ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm
(left):

https://codereview.chromium.org/2594793004/diff/1/ios/chrome/browser/ui/overs...
ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm:590:
[_webViewScrollViewProxy setContentInsetFast:contentInset];
Are you sure that this does not break Pull To Action? I think that |_scrollview|
is nil if OverscrollActionsController is attached to a view with WebState. A few
days ago, I checked that |setContentInsetFast:| is still called.

[Eugene But (OOO till 7-30), 2016-12-21 19:15:01]

https://codereview.chromium.org/2594793004/diff/1/ios/chrome/browser/ui/overs...
File ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm
(left):

https://codereview.chromium.org/2594793004/diff/1/ios/chrome/browser/ui/overs...
ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm:590:
[_webViewScrollViewProxy setContentInsetFast:contentInset];
On 2016/12/21 18:48:43, Eugene But wrote:
> Are you sure that this does not break Pull To Action? I think that
|_scrollview|
> is nil if OverscrollActionsController is attached to a view with WebState. A
few
> days ago, I checked that |setContentInsetFast:| is still called.
Ok. I tested this change and it breaks overscroll.

1.) Search for puppies in the omnibox
2.) pull page to reveal overscroll controls
3.) Release toolbar w/o activating any actions

Actual result:
Overscroll overlay does not go away

[Eugene But (OOO till 7-30), 2016-12-21 19:26:53]

lgtm, thank you for cleanup!

[justincohen, 2016-12-21 19:59:45]

https://codereview.chromium.org/2594793004/diff/1/ios/chrome/browser/ui/fulls...
File ios/chrome/browser/ui/fullscreen_controller.h (right):

https://codereview.chromium.org/2594793004/diff/1/ios/chrome/browser/ui/fulls...
ios/chrome/browser/ui/fullscreen_controller.h:109: // Update the insets during
animation.
On 2016/12/21 18:48:43, Eugene But wrote:
> s/Update/Updates

Done.

https://codereview.chromium.org/2594793004/diff/1/ios/chrome/browser/ui/overs...
File ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm
(left):

https://codereview.chromium.org/2594793004/diff/1/ios/chrome/browser/ui/overs...
ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm:590:
[_webViewScrollViewProxy setContentInsetFast:contentInset];
On 2016/12/21 18:48:43, Eugene But wrote:
> Are you sure that this does not break Pull To Action? I think that
|_scrollview|
> is nil if OverscrollActionsController is attached to a view with WebState. A
few
> days ago, I checked that |setContentInsetFast:| is still called.

Done.

[justincohen, 2016-12-21 20:03:53]

The CQ bit was checked by justincohen@chromium.org

[commit-bot: I haz the power, 2016-12-21 20:04:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 20:17:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482350633924580,
"parent_rev": "663151822c3642ec649b4ae2ef41931a5ae2af56", "commit_rev":
"68273af7b9cd6896677c90b212446041f3149971"}

[commit-bot: I haz the power, 2016-12-21 20:17:40]

Description was changed from

==========
Revert 'Bypass UIWebView.scrollView's contentInset implementation with
UIScrollView's.

We had already stopped using this in full screen controller when we moved to
WKWebView, but pull-to-action and some cruft remained.

BUG=675746
==========

to

==========
Revert 'Bypass UIWebView.scrollView's contentInset implementation with
UIScrollView's.

We had already stopped using this in full screen controller when we moved to
WKWebView, but pull-to-action and some cruft remained.

BUG=675746

Review-Url: https://codereview.chromium.org/2594793004
==========

[commit-bot: I haz the power, 2016-12-21 20:17:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-21 20:21:09]

Description was changed from

==========
Revert 'Bypass UIWebView.scrollView's contentInset implementation with
UIScrollView's.

We had already stopped using this in full screen controller when we moved to
WKWebView, but pull-to-action and some cruft remained.

BUG=675746

Review-Url: https://codereview.chromium.org/2594793004
==========

to

==========
Revert 'Bypass UIWebView.scrollView's contentInset implementation with
UIScrollView's.

We had already stopped using this in full screen controller when we moved to
WKWebView, but pull-to-action and some cruft remained.

BUG=675746

Committed: https://crrev.com/04c2777134dd67f93da8d059c973521e18e8e55b
Cr-Commit-Position: refs/heads/master@{#440198}
==========

[commit-bot: I haz the power, 2016-12-21 20:21:10]

Patchset 2 (id:??) landed as
https://crrev.com/04c2777134dd67f93da8d059c973521e18e8e55b
Cr-Commit-Position: refs/heads/master@{#440198}