Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Side by Side Diff: ios/chrome/browser/ui/fullscreen_controller.h

Issue 2594793004: Revert 'Bypass UIWebView.scrollView's contentInset implementation with UIScrollView's. (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_CHROME_BROWSER_UI_FULLSCREEN_CONTROLLER_H_ 5 #ifndef IOS_CHROME_BROWSER_UI_FULLSCREEN_CONTROLLER_H_
6 #define IOS_CHROME_BROWSER_UI_FULLSCREEN_CONTROLLER_H_ 6 #define IOS_CHROME_BROWSER_UI_FULLSCREEN_CONTROLLER_H_
7 7
8 #import <UIKit/UIKit.h> 8 #import <UIKit/UIKit.h>
9 9
10 #import "ios/web/public/web_state/crw_web_controller_observer.h" 10 #import "ios/web/public/web_state/crw_web_controller_observer.h"
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 // matter what the scrollview is doing. 99 // matter what the scrollview is doing.
100 - (void)disableFullScreen; 100 - (void)disableFullScreen;
101 // Enabling fullscreen will reverse the effect of a call to -disableFullScreen. 101 // Enabling fullscreen will reverse the effect of a call to -disableFullScreen.
102 // The toolbar will stay on screen until a move pushes it out. 102 // The toolbar will stay on screen until a move pushes it out.
103 - (void)enableFullScreen; 103 - (void)enableFullScreen;
104 104
105 // Skip next attempt to correct the scroll offset for the toolbar height. This 105 // Skip next attempt to correct the scroll offset for the toolbar height. This
106 // is necessary when programatically scrolling down the y offset. 106 // is necessary when programatically scrolling down the y offset.
107 - (void)shouldSkipNextScrollOffsetForHeader; 107 - (void)shouldSkipNextScrollOffsetForHeader;
108 108
109 // Update the insets during animation. When |forceUpdate| is set to NO, a faster 109 // Update the insets during animation.
Eugene But (OOO till 7-30) 2016/12/21 18:48:43 s/Update/Updates
justincohen 2016/12/21 19:59:45 Done.
110 // workaround implemention is used to update the content's offset. That 110 - (void)setToolbarInsetsForHeaderOffset:(CGFloat)headerOffset;
111 // implemention does not cause a full update. |forceUpdate| should only be set
112 // to |NO| when -setToolbarInsetsForHeaderOffset is called
113 // in quick succession during scroll callbacks.
114 - (void)setToolbarInsetsForHeaderOffset:(CGFloat)headerOffset
115 forceUpdate:(BOOL)forceUpdate;
116 111
117 // Set the content offset of the underlying UIScrollView so that the content 112 // Set the content offset of the underlying UIScrollView so that the content
118 // is not hidden by the header. The header will be moved to its visible position 113 // is not hidden by the header. The header will be moved to its visible position
119 // without animation if it is not already fully visible. 114 // without animation if it is not already fully visible.
120 - (void)moveContentBelowHeader; 115 - (void)moveContentBelowHeader;
121 @end 116 @end
122 117
123 @interface FullScreenController (UsedForTesting) 118 @interface FullScreenController (UsedForTesting)
124 // Enables/Disables the FullScreenController in tests. The unit tests do not set 119 // Enables/Disables the FullScreenController in tests. The unit tests do not set
125 // the delegate which is crucial for methods to work on the controller. 120 // the delegate which is crucial for methods to work on the controller.
126 // This a temporary solution. 121 // This a temporary solution.
127 // TODO(shreyasv): Find a better solution/remove this when FullScreenController 122 // TODO(shreyasv): Find a better solution/remove this when FullScreenController
128 // moves to Tab. 123 // moves to Tab.
129 + (void)setEnabledForTests:(BOOL)enabled; 124 + (void)setEnabledForTests:(BOOL)enabled;
130 @end 125 @end
131 126
132 #endif // IOS_CHROME_BROWSER_UI_FULLSCREEN_CONTROLLER_H_ 127 #endif // IOS_CHROME_BROWSER_UI_FULLSCREEN_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698