Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2594773002:
Disable failing resolutions for Webcam test on Win8 bot (Closed)
DescriptionDisable failing resolutions for Webcam test on Win8 bot
BUG=676041
Committed: https://crrev.com/f824c13d23fd8e7d91887f40d028d112765b73fe
Cr-Commit-Position: refs/heads/master@{#439929}
Patch Set 1 #
Total comments: 4
Patch Set 2 : reviewers comments #Patch Set 3 : Add missing include #Patch Set 4 : Added missing namespace qualifiers #Messages
Total messages: 34 (22 generated)
Description was changed from ========== Disable failing resolutions for Win8 bot BUG= ========== to ========== Disable failing resolutions for Webcam test on Win8 bot BUG=676041 ==========
chfremer@chromium.org changed reviewers: + emircan@chromium.org, mcasas@chromium.org
PTAL
The CQ bit was checked by chfremer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2594773002/diff/1/chrome/browser/media/webrtc... File chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc (right): https://codereview.chromium.org/2594773002/diff/1/chrome/browser/media/webrtc... chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc:91: #if defined(OS_WIN) Can you move this #if clause to 104 and return inside? You wouldn't need |disable_720p_and_up| then.
lgtm can you please add more info in the CL? E.g. mention that this only affects chromium.webrtc waterfall, and what caused it to start failing (i.e. reenabling the tests), etc. for the QA folks to be able to parse it quickly. https://codereview.chromium.org/2594773002/diff/1/chrome/browser/media/webrtc... File chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc (right): https://codereview.chromium.org/2594773002/diff/1/chrome/browser/media/webrtc... chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc:89: // See crbug.com/676041 nit: can you rephrase this comment more TODO-ish plz? // TODO(chfremer): Reenable these tests, https://crbug.com/676041.
chfremer@chromium.org changed reviewers: + sergeyu@chromium.org
sergeyu@chromium.org: Please RS https://codereview.chromium.org/2594773002/diff/1/chrome/browser/media/webrtc... File chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc (right): https://codereview.chromium.org/2594773002/diff/1/chrome/browser/media/webrtc... chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc:89: // See crbug.com/676041 On 2016/12/20 18:57:41, mcasas wrote: > nit: can you rephrase this comment more TODO-ish plz? > > // TODO(chfremer): Reenable these tests, https://crbug.com/676041. Done. https://codereview.chromium.org/2594773002/diff/1/chrome/browser/media/webrtc... chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc:91: #if defined(OS_WIN) On 2016/12/20 18:57:28, emircan wrote: > Can you move this #if clause to 104 and return inside? You wouldn't need > |disable_720p_and_up| then. Done.
chfremer@chromium.org changed reviewers: + kjellander@chromium.org
kjellander@: FYI
lgtm
lgtm
The CQ bit was checked by chfremer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org Link to the patchset: https://codereview.chromium.org/2594773002/#ps20001 (title: "reviewers comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by chfremer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by chfremer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by chfremer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org, emircan@chromium.org, mcasas@chromium.org Link to the patchset: https://codereview.chromium.org/2594773002/#ps60001 (title: "Added missing namespace qualifiers")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482276520159480,
"parent_rev": "397fbdc79d0b2b6f875db94e7b3f92c581f2e110", "commit_rev":
"9076a6a7e9262eeb9359fd202b4b4ccf8183ef28"}
Message was sent while issue was closed.
Description was changed from ========== Disable failing resolutions for Webcam test on Win8 bot BUG=676041 ========== to ========== Disable failing resolutions for Webcam test on Win8 bot BUG=676041 Review-Url: https://codereview.chromium.org/2594773002 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Disable failing resolutions for Webcam test on Win8 bot BUG=676041 Review-Url: https://codereview.chromium.org/2594773002 ========== to ========== Disable failing resolutions for Webcam test on Win8 bot BUG=676041 Committed: https://crrev.com/f824c13d23fd8e7d91887f40d028d112765b73fe Cr-Commit-Position: refs/heads/master@{#439929} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/f824c13d23fd8e7d91887f40d028d112765b73fe Cr-Commit-Position: refs/heads/master@{#439929} |
