Disable failing resolutions for Webcam test on Win8 bot

chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "build/build_config.h"
 #include "chrome/browser/media/webrtc/webrtc_browsertest_base.h"
 #include "chrome/browser/media/webrtc/webrtc_browsertest_common.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
@@ skipping 65 matching lines @@
   GURL url(embedded_test_server()->GetURL(kMainWebrtcTestHtmlPage));
   ui_test_utils::NavigateToURL(browser(), url);
   content::WebContents* tab =
       browser()->tab_strip_model()->GetActiveWebContents();
 
   if (!content::IsWebcamAvailableOnSystem(tab)) {
     DVLOG(0) << "No webcam found on bot: skipping...";
     return;
   }
 
+  // We have a Win8 bot failing at resolution "1280x720", which may or may not
+  // be due to its physical webcam not supporting that resolution.
+  // We disable those resolutions for Win8 until we find the root cause.
+  // See crbug.com/676041

[mcasas, 2016/12/20 18:57:41]

nit: can you rephrase this comment more TODO-ish plz?

// TODO(chfremer): Reenable these tests, https://crbug.com/676041.

[chfremer, 2016/12/20 19:11:00]

Done.

+  bool disable_720p_and_up = false;
+#if defined(OS_WIN)

[emircan, 2016/12/20 18:57:28]

Can you move this #if clause to 104 and return inside? You wouldn't need
|disable_720p_and_up| then.

[chfremer, 2016/12/20 19:11:00]

Done.

+  auto win_version = base::win::GetVersion();
+  disable_720p_and_up =
+      (win_version == VERSION_WIN8 || win_version == VERSION_WIN8_1);
+#endif
+
   EXPECT_EQ("320x240",
             GetUserMediaAndGetStreamSize(tab, kVideoCallConstraintsQVGA));
   EXPECT_EQ("640x480",
             GetUserMediaAndGetStreamSize(tab, kVideoCallConstraintsVGA));
   EXPECT_EQ("640x360",
             GetUserMediaAndGetStreamSize(tab, kVideoCallConstraints360p));
+
+  if (disable_720p_and_up)
+    return;
+
   EXPECT_EQ("1280x720",
             GetUserMediaAndGetStreamSize(tab, kVideoCallConstraints720p));
   EXPECT_EQ("1920x1080",
             GetUserMediaAndGetStreamSize(tab, kVideoCallConstraints1080p));
 }
 
 INSTANTIATE_TEST_CASE_P(WebRtcWebcamBrowserTests,
                         WebRtcWebcamBrowserTest,
                         testing::ValuesIn(kTestConfigFlags));