Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: content/browser/dom_storage/dom_storage_context_wrapper.cc

Issue 2594723002: Count number of origins with data affected by clearing "cookies and site data". (Closed)
Patch Set: Add comments for issues with incomplete data deletion Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/dom_storage/dom_storage_context_wrapper.cc
diff --git a/content/browser/dom_storage/dom_storage_context_wrapper.cc b/content/browser/dom_storage/dom_storage_context_wrapper.cc
index 926b4c0feb646961094a9d79062c1f0bf5675766..077c2bc346ed0ba18f61f0e93d1dac885561aa0c 100644
--- a/content/browser/dom_storage/dom_storage_context_wrapper.cc
+++ b/content/browser/dom_storage/dom_storage_context_wrapper.cc
@@ -170,9 +170,12 @@ void DOMStorageContextWrapper::GetSessionStorageUsage(
base::RetainedRef(context_), callback));
}
+
msramek 2017/01/09 12:54:44 style: This empty line is superfluous.
void DOMStorageContextWrapper::DeleteLocalStorageForPhysicalOrigin(
const GURL& origin) {
DCHECK(context_.get());
+ // TODO? This method sometimes leaves traces of localstorage behind that show
msramek 2017/01/09 12:54:44 Let's file this one as a bug as well. Please leave
dullweber 2017/01/09 16:05:46 I filed it as http://crbug.com/679344
+ // that there was localstorage for an origin. I didn't find a way to fix this.
context_->task_runner()->PostShutdownBlockingTask(
FROM_HERE, DOMStorageTaskRunner::PRIMARY_SEQUENCE,
base::Bind(&DOMStorageContextImpl::DeleteLocalStorageForPhysicalOrigin,

Powered by Google App Engine
This is Rietveld 408576698