Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: content/browser/dom_storage/dom_storage_context_impl.cc

Issue 2594723002: Count number of origins with data affected by clearing "cookies and site data". (Closed)
Patch Set: Add comments for issues with incomplete data deletion Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/dom_storage/dom_storage_context_impl.cc
diff --git a/content/browser/dom_storage/dom_storage_context_impl.cc b/content/browser/dom_storage/dom_storage_context_impl.cc
index 2b945dea40fc23536b5d7a92c92dc133fcad4fa0..9daad33aa26e9c1b367ca588fd2faad7ba62552e 100644
--- a/content/browser/dom_storage/dom_storage_context_impl.cc
+++ b/content/browser/dom_storage/dom_storage_context_impl.cc
@@ -256,6 +256,15 @@ void DOMStorageContextImpl::DeleteSessionStorage(
dom_storage_namespace = GetStorageNamespace(namespace_id);
}
dom_storage_namespace->DeleteSessionStorageOrigin(usage_info.origin);
+ // TODO? This removes remaining traces of deleted sessions but I don't know if
+ // it could interfere with whatever happens with this clear event below?
+ /*if (session_storage_database_.get()) {
msramek 2017/01/09 12:54:44 Since you already know how to solve it, just need
dullweber 2017/01/09 16:05:46 I created https://codereview.chromium.org/26226030
+ task_runner_->PostShutdownBlockingTask(
+ FROM_HERE, DOMStorageTaskRunner::COMMIT_SEQUENCE,
+ base::Bind(base::IgnoreResult(&SessionStorageDatabase::DeleteArea),
+ session_storage_database_,
+ usage_info.persistent_namespace_id, usage_info.origin));
+ }*/
// Synthesize a 'cleared' event if the area is open so CachedAreas in
// renderers get emptied out too.
DOMStorageArea* area =

Powered by Google App Engine
This is Rietveld 408576698