Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: storage/browser/fileapi/file_system_quota_client.cc

Issue 2594723002: Count number of origins with data affected by clearing "cookies and site data". (Closed)
Patch Set: Add comments for issues with incomplete data deletion Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: storage/browser/fileapi/file_system_quota_client.cc
diff --git a/storage/browser/fileapi/file_system_quota_client.cc b/storage/browser/fileapi/file_system_quota_client.cc
index 26fde452d6a8f0b931157158a1799a5d2aab872e..dfb32ef34aa9148666968764d5769138c9837a1b 100644
--- a/storage/browser/fileapi/file_system_quota_client.cc
+++ b/storage/browser/fileapi/file_system_quota_client.cc
@@ -167,9 +167,13 @@ void FileSystemQuotaClient::DeleteOriginData(
const GURL& origin,
StorageType type,
const DeletionCallback& callback) {
+ // TODO? This method only deletes filesytem entries associated with a quota
msramek 2017/01/09 12:54:44 Let's ask FS owners about this.
dullweber 2017/01/09 16:05:46 I created http://crbug.com/679362 for it.
+ // type but there are much more kinds of filesystems, which don't get deleted?
+ // Maybe use FileSystemContext::DeleteDataForOriginOnFileTaskRunner, which
+ // iterates over all backends?
FileSystemType fs_type = QuotaStorageTypeToFileSystemType(type);
DCHECK(fs_type != kFileSystemTypeUnknown);
-
+ LOG(ERROR) << "deleting filesystem entry: " << origin.spec();
base::PostTaskAndReplyWithResult(
file_task_runner(), FROM_HERE,
base::Bind(&DeleteOriginOnFileTaskRunner,

Powered by Google App Engine
This is Rietveld 408576698