Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4350)

Unified Diff: chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm

Issue 2594543004: [Mac] Fix bubble anchors in RTL (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm b/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
index 78af75adc58a6c73e09dd01ed134131809f5a5a6..58adbacc169be7d80bf28dcc4bdcf4483d793ef1 100644
--- a/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
+++ b/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
@@ -8,6 +8,7 @@
#include "base/strings/string16.h"
#include "base/strings/string_number_conversions.h"
#include "chrome/app/chrome_command_ids.h"
+#import "chrome/browser/ui/cocoa/l10n_util.h"
#import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.h"
#import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h"
#import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
@@ -116,7 +117,10 @@ void ZoomDecoration::ShowAndUpdateUI(zoom::ZoomController* zoom_controller,
}
NSPoint ZoomDecoration::GetBubblePointInFrame(NSRect frame) {
- return NSMakePoint(NSMaxX(frame), NSMaxY(frame));
+ return NSMakePoint(cocoa_l10n_util::ShouldDoExperimentalRTLLayout()
+ ? NSMinX(frame)
+ : NSMaxX(frame),
+ NSMaxY(frame));
}
bool ZoomDecoration::IsAtDefaultZoom() const {
« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698