Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2594513002: Use MockRenderProcessHost in memory coordinator unittests (Closed)

Created:
4 years ago by bashi
Modified:
4 years ago
Reviewers:
haraken, chrisha
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use MockRenderProcessHost in memory coordinator unittests Calling RenderProcessHost::FromID() directly prevents us to write unittests. Add a virtual method for getting RenderProcessHost so that testing code can use MockRenderProcessHost to write unittests. Also, this CL installs a MemoryCoordinatorDelegate in unittests so that unittests can have wider coverage. BUG=675811 Committed: https://crrev.com/d37e4c892eed8e2ad96de67f347254b846531ede Cr-Commit-Position: refs/heads/master@{#439764}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -15 lines) Patch
M content/browser/memory/memory_coordinator_impl.h View 3 chunks +11 lines, -3 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl.cc View 4 chunks +16 lines, -11 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl_unittest.cc View 8 chunks +48 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
bashi
PTAL
4 years ago (2016-12-20 06:30:58 UTC) #4
haraken
LGTM
4 years ago (2016-12-20 09:42:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594513002/1
4 years ago (2016-12-20 10:36:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 10:41:58 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-20 10:45:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d37e4c892eed8e2ad96de67f347254b846531ede
Cr-Commit-Position: refs/heads/master@{#439764}

Powered by Google App Engine
This is Rietveld 408576698