Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2586873002: Change type of MemoryCoordinatorImpl::ChildInfo::memory_state (Closed)

Created:
4 years ago by bashi
Modified:
4 years ago
Reviewers:
haraken, chrisha
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change type of MemoryCoordinatorImpl::ChildInfo::memory_state This CL changes the type of MemoryCoordinatorImpl::ChildInfo::memory_state from mojom::MemoryState to base::MemoryState. The reason of this change is to avoid unnecessary type conversion. We are planning to add public interface of memory coordinator so that chrome/ can access memory state of each process. Since mojom::MemoryState is only accessible from content/ we have to convert mojom::MemoryState to base::MemoryState when we expose memory state outside content/. By storing states as base::MemoryState we can eliminate type conversion. BUG=673216 Committed: https://crrev.com/3453c17646a103f98c4611311de373a7d40ff957 Cr-Commit-Position: refs/heads/master@{#439734}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M content/browser/memory/memory_coordinator_impl.h View 3 chunks +5 lines, -6 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl.cc View 6 chunks +16 lines, -17 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl_unittest.cc View 7 chunks +14 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
bashi
This depends on https://codereview.chromium.org/2579233002/ but trivial refactoring. PTAL?
4 years ago (2016-12-19 06:48:48 UTC) #2
haraken
LGTM
4 years ago (2016-12-19 06:50:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2586873002/20001
4 years ago (2016-12-20 06:17:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-20 07:45:45 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-20 07:49:44 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3453c17646a103f98c4611311de373a7d40ff957
Cr-Commit-Position: refs/heads/master@{#439734}

Powered by Google App Engine
This is Rietveld 408576698