third_party: Add libdrm.

third_party: Add libdrm.

libdrm shipped with the sysroot or our workstation is older than libdrm
we use on chromeos.
This forces us to redefine symbols/defines (fourcc code for example) and
doesn't allow us to compile newer drm code on trybots (drm atomic).

This CLs adds libdrm to third_party, so that we can build the third_party
one when we build on our workstation or on the trybot, similar to what
we currently do with minigbm.

BUG=

Committed: https://crrev.com/141830582db701ab4edf529ae876906a6508cf7a
Cr-Commit-Position: refs/heads/master@{#439907}

[Daniele Castagna, 2016-12-20 01:36:24]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 01:37:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniele Castagna, 2016-12-20 01:37:55]

dcastagna@chromium.org changed reviewers:
+ reveman@chromium.org, thomasanderson@chromium.org

[Daniele Castagna, 2016-12-20 01:40:19]

dcastagna@chromium.org changed reviewers:
+ gurchetansingh@chromium.org

[gurchetansingh, 2016-12-20 01:43:50]

On 2016/12/20 01:40:20, Daniele Castagna wrote:

lgtm

[rjkroege, 2016-12-20 01:48:56]

On 2016/12/20 01:43:50, gurchetansingh wrote:
> On 2016/12/20 01:40:20, Daniele Castagna wrote:
> 
> lgtm

Apologies for what's conceivably a foolish question but why not  freshen the
sysroot? And if this is coming from third_party, don't you need/want to change
the sysroots?

[Daniele Castagna, 2016-12-20 01:58:33]

On 2016/12/20 at 01:48:56, rjkroege wrote:
> On 2016/12/20 01:43:50, gurchetansingh wrote:
> > On 2016/12/20 01:40:20, Daniele Castagna wrote:
> > 
> > lgtm
> 
> Apologies for what's conceivably a foolish question but why not  freshen the
sysroot? And if this is coming from third_party, don't you need/want to change
the sysroots?

I spent the day trying, let me summarize it here. thomasanderson can add to it
since he has been helping me all day long.

Right now we have two sysroots: Ubuntu Precise and Debian Wheezy. libdrm shipped
with those is too old.
There has been some effort to move to a new sysroot (should happen this week)
that is based on Debian Jessie.

We tried using Debian Jessie and the libdrm shipped with it is too old, all the
other libraries seem ok, at least to build ozone_demo. thomasanderson said there
is no way of using a newer libdrm package at the moment.

I tried to create a new sysroot with Ubuntu Trusty. That might work, but I'm not
sure we want to maintain another sysroot. It'd be actually nice if we could get
rid of the custom chromeos one and just use Jessie one for every build.

That leaves us with this option.

[Tom Anderson, 2016-12-20 02:08:43]

lgtm

[commit-bot: I haz the power, 2016-12-20 02:13:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 02:13:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Daniele Castagna, 2016-12-20 02:14:01]

The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 02:14:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reveman, 2016-12-20 02:21:36]

lgtm

[Daniele Castagna, 2016-12-20 04:09:12]

On 2016/12/20 at 01:48:56, rjkroege wrote:
> On 2016/12/20 01:43:50, gurchetansingh wrote:
> > On 2016/12/20 01:40:20, Daniele Castagna wrote:
> > 
> > lgtm
> 
> Apologies for what's conceivably a foolish question but why not  freshen the
sysroot? And if this is coming from third_party, don't you need/want to change
the sysroots?

As per discussion via IM. I tried to remove libdrm-dev from precise sysroot.
Unfortunately wayland-egl and possibly other libraries in the sysroot depend on
libdrm-dev.

[commit-bot: I haz the power, 2016-12-20 04:46:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 04:46:37]

Dry run: This issue passed the CQ dry run.

[Daniele Castagna, 2016-12-20 19:29:34]

It seems that crrev.com/2576263002 will also need something like this since it
depends on recent libdrm changes.

rjkroege@, are you OK with this or do you prefer to try to do something
different?

[rjkroege, 2016-12-20 19:35:28]

rjkroege@chromium.org changed reviewers:
+ rjkroege@chromium.org

[rjkroege, 2016-12-20 19:35:29]

Thanks for looking into the issue that I raised. As we discussed, I see a
possible problem here. Maybe we could have a proj-ozone bug to do something
smarter?

Anyway: ozone changes lgtm

[Daniele Castagna, 2016-12-20 22:04:50]

dcastagna@chromium.org changed reviewers:
+ marcheu@chromium.org

[Daniele Castagna, 2016-12-20 22:04:51]

On 2016/12/20 at 19:35:29, rjkroege wrote:
> Thanks for looking into the issue that I raised. As we discussed, I see a
possible problem here. Maybe we could have a proj-ozone bug to do something
smarter?
> 
Filed crbug.com/676119 to track the issue.
It should be possible to remove libdrm from the precise sysroot, since we could
get rid of wayland-egl if we did surfaceless wayland.
It'd be also nice to just get rid of the Precise sysroot and just use the new
Jessie one.

> Anyway: ozone changes lgtm

Thank you!

+marcheu for minigbm ownership.

[marcheu1, 2016-12-20 22:32:45]

marcheu@google.com changed reviewers:
+ marcheu@google.com

[marcheu1, 2016-12-20 22:32:46]

lgtm

[Daniele Castagna, 2016-12-20 22:33:37]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2016-12-20 22:33:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
thomasanderson@chromium.org, gurchetansingh@chromium.org
Link to the patchset: https://codereview.chromium.org/2594483002/#ps20001
(title: "Add libdrm deps to gbm_unittests.")

[commit-bot: I haz the power, 2016-12-20 22:34:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 22:47:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 22:47:50]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Daniele Castagna, 2016-12-20 22:53:22]

On 2016/12/20 at 22:32:46, marcheu wrote:
> lgtm

I think you might need to use your chromium account.

[marcheu, 2016-12-20 22:55:01]

On 2016/12/20 22:53:22, Daniele Castagna wrote:
> On 2016/12/20 at 22:32:46, marcheu wrote:
> > lgtm
> 
> I think you might need to use your chromium account.

lgtm

[Daniele Castagna, 2016-12-20 22:55:34]

The CQ bit was checked by dcastagna@chromium.org

[commit-bot: I haz the power, 2016-12-20 22:56:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 23:03:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482274534118170,
"parent_rev": "ebd360462e6cfe17a50e713e91947431d0e57e39", "commit_rev":
"67b8c751915b1f4b71c0e2a2cb690558929941cf"}

[commit-bot: I haz the power, 2016-12-20 23:04:14]

Description was changed from

==========
third_party: Add libdrm.

libdrm shipped with the sysroot or our workstation is older than libdrm
we use on chromeos.
This forces us to redefine symbols/defines (fourcc code for example) and
doesn't allow us to compile newer drm code on trybots (drm atomic).

This CLs adds libdrm to third_party, so that we can build the third_party
one when we build on our workstation or on the trybot, similar to what
we currently do with minigbm.

BUG=
==========

to

==========
third_party: Add libdrm.

libdrm shipped with the sysroot or our workstation is older than libdrm
we use on chromeos.
This forces us to redefine symbols/defines (fourcc code for example) and
doesn't allow us to compile newer drm code on trybots (drm atomic).

This CLs adds libdrm to third_party, so that we can build the third_party
one when we build on our workstation or on the trybot, similar to what
we currently do with minigbm.

BUG=

Review-Url: https://codereview.chromium.org/2594483002
==========

[commit-bot: I haz the power, 2016-12-20 23:04:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-20 23:07:40]

Description was changed from

==========
third_party: Add libdrm.

libdrm shipped with the sysroot or our workstation is older than libdrm
we use on chromeos.
This forces us to redefine symbols/defines (fourcc code for example) and
doesn't allow us to compile newer drm code on trybots (drm atomic).

This CLs adds libdrm to third_party, so that we can build the third_party
one when we build on our workstation or on the trybot, similar to what
we currently do with minigbm.

BUG=

Review-Url: https://codereview.chromium.org/2594483002
==========

to

==========
third_party: Add libdrm.

libdrm shipped with the sysroot or our workstation is older than libdrm
we use on chromeos.
This forces us to redefine symbols/defines (fourcc code for example) and
doesn't allow us to compile newer drm code on trybots (drm atomic).

This CLs adds libdrm to third_party, so that we can build the third_party
one when we build on our workstation or on the trybot, similar to what
we currently do with minigbm.

BUG=

Committed: https://crrev.com/141830582db701ab4edf529ae876906a6508cf7a
Cr-Commit-Position: refs/heads/master@{#439907}
==========

[commit-bot: I haz the power, 2016-12-20 23:07:41]

Patchset 2 (id:??) landed as
https://crrev.com/141830582db701ab4edf529ae876906a6508cf7a
Cr-Commit-Position: refs/heads/master@{#439907}