Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2594453002: Remove duplicated UMA recording when destructing SafeBrowsingErrorUI. (Closed)

Created:
4 years ago by Jialiu Lin
Modified:
4 years ago
Reviewers:
Nathan Parker
CC:
chromium-reviews, meacer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicated UMA recording when destructing SafeBrowsingErrorUI. Unlike SSL interstitial, when destructing safe browsing interstitial, SafeBrowsingBlockingPage::OnDontProceed() function gets called. This function takes cares of recording the DONT_PROCEED action. Therefore, no need to recording DONT_PROCEED in SafeBrowsingErrorUI's destructor. BUG=675786 Committed: https://crrev.com/19f322ce5c257661c75c178315db05f342dec57c Cr-Commit-Position: refs/heads/master@{#439672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M components/security_interstitials/core/safe_browsing_error_ui.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/security_interstitials/core/safe_browsing_error_ui.cc View 4 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Jialiu Lin
Hi nparker@, This CL is for fixing a regression on interstitial.malware/phishing/harmful.decision UMA metrics. This regression ...
4 years ago (2016-12-20 00:43:03 UTC) #4
Nathan Parker
lgtm
4 years ago (2016-12-20 01:05:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594453002/1
4 years ago (2016-12-20 01:52:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 02:22:58 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-20 02:25:49 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19f322ce5c257661c75c178315db05f342dec57c
Cr-Commit-Position: refs/heads/master@{#439672}

Powered by Google App Engine
This is Rietveld 408576698