Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: components/security_interstitials/core/safe_browsing_error_ui.cc

Issue 2594453002: Remove duplicated UMA recording when destructing SafeBrowsingErrorUI. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/security_interstitials/core/safe_browsing_error_ui.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/security_interstitials/core/safe_browsing_error_ui.cc
diff --git a/components/security_interstitials/core/safe_browsing_error_ui.cc b/components/security_interstitials/core/safe_browsing_error_ui.cc
index a6a5bb6b16d649a4a8b599aff4d50f08ca4c2bd4..7c9a1e60b1e5aed3672baae376f568f8f8b30eed 100644
--- a/components/security_interstitials/core/safe_browsing_error_ui.cc
+++ b/components/security_interstitials/core/safe_browsing_error_ui.cc
@@ -64,8 +64,7 @@ SafeBrowsingErrorUI::SafeBrowsingErrorUI(
display_options_(display_options),
app_locale_(app_locale),
time_triggered_(time_triggered),
- controller_(controller),
- user_made_decision_(false) {
+ controller_(controller) {
controller_->metrics_helper()->RecordUserDecision(MetricsHelper::SHOW);
controller_->metrics_helper()->RecordUserInteraction(
MetricsHelper::TOTAL_VISITS);
@@ -75,12 +74,6 @@ SafeBrowsingErrorUI::SafeBrowsingErrorUI(
}
SafeBrowsingErrorUI::~SafeBrowsingErrorUI() {
- // If the page is closing without an explicit decision, record it as not
- // proceeding.
- if (!user_made_decision_) {
- controller_->metrics_helper()->RecordUserDecision(
- MetricsHelper::DONT_PROCEED);
- }
controller_->metrics_helper()->RecordShutdownMetrics();
}
@@ -128,7 +121,6 @@ void SafeBrowsingErrorUI::HandleCommand(SecurityInterstitialCommands command) {
controller_->metrics_helper()->RecordUserDecision(
MetricsHelper::PROCEED);
controller_->Proceed();
- user_made_decision_ = true;
break;
}
}
@@ -147,7 +139,6 @@ void SafeBrowsingErrorUI::HandleCommand(SecurityInterstitialCommands command) {
// commits.
controller_->GoBackAfterNavigationCommitted();
}
- user_made_decision_ = true;
break;
}
case CMD_DO_REPORT: {
« no previous file with comments | « components/security_interstitials/core/safe_browsing_error_ui.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698