Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2594253002: Lift texture's MAX_LEVEL/BASE_LEVEL workaround on OSX 10.12.2+ with AMD GPU. (Closed)

Created:
4 years ago by Zhenyao Mo
Modified:
4 years ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Lift texture's MAX_LEVEL/BASE_LEVEL workaround on OSX 10.12.2+ with AMD GPU. The driver has been fixed in 10.12.2 BUG=610153 TEST= TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/2347b6c10bbe0810aa8eb3ceb8bf583ff74a9dd8 Cr-Commit-Position: refs/heads/master@{#440319}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +6 lines, -2 lines 2 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
Ken Russell (switch to Gerrit)
lgtm with question https://codereview.chromium.org/2594253002/diff/1/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2594253002/diff/1/gpu/config/gpu_driver_bug_list_json.cc#newcode1745 gpu/config/gpu_driver_bug_list_json.cc:1745: "value": "10.12.2" Do we understand these ...
4 years ago (2016-12-22 00:44:23 UTC) #2
Zhenyao Mo
https://codereview.chromium.org/2594253002/diff/1/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2594253002/diff/1/gpu/config/gpu_driver_bug_list_json.cc#newcode1745 gpu/config/gpu_driver_bug_list_json.cc:1745: "value": "10.12.2" On 2016/12/22 00:44:23, Ken Russell wrote: > ...
4 years ago (2016-12-22 00:45:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594253002/1
4 years ago (2016-12-22 00:45:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 02:47:39 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-22 02:50:08 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2347b6c10bbe0810aa8eb3ceb8bf583ff74a9dd8
Cr-Commit-Position: refs/heads/master@{#440319}

Powered by Google App Engine
This is Rietveld 408576698