Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2594183002: WebUI: Delete cr-shared-menu, no longer used. (Closed)

Created:
4 years ago by dpapad
Modified:
4 years ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, vitalyp+closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Delete cr-shared-menu, no longer used. BUG=658821 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/589ca5c5c3b6aaa0c5a58f489079ab6e1039e67a Cr-Commit-Position: refs/heads/master@{#440327}

Patch Set 1 #

Patch Set 2 : Fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -495 lines) Patch
M chrome/test/data/webui/cr_elements/cr_elements_browsertest.js View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/test/data/webui/cr_elements/cr_shared_menu_tests.js View 1 chunk +0 lines, -240 lines 0 comments Download
D ui/webui/resources/cr_elements/cr_shared_menu/compiled_resources2.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
D ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.html View 1 chunk +0 lines, -33 lines 0 comments Download
D ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js View 1 chunk +0 lines, -179 lines 0 comments Download
M ui/webui/resources/cr_elements_resources.grdp View 1 1 chunk +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (14 generated)
dpapad
4 years ago (2016-12-21 23:42:55 UTC) #9
Dan Beam
lgtm so long, good friend
4 years ago (2016-12-22 00:25:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594183002/20001
4 years ago (2016-12-22 01:57:53 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-22 03:42:00 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-22 03:43:40 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/589ca5c5c3b6aaa0c5a58f489079ab6e1039e67a
Cr-Commit-Position: refs/heads/master@{#440327}

Powered by Google App Engine
This is Rietveld 408576698