Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2594163002: DevTools: Add missing case to DoAction switch (Closed)

Created:
3 years, 12 months ago by einbinder
Modified:
3 years, 12 months ago
Reviewers:
caseq, dgozman
CC:
chromium-reviews, devtools-reviews_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Add missing case to DoAction switch BUG=673472 Committed: https://crrev.com/2de169544dd69ffc7e31e87be92add166397ed12 Cr-Commit-Position: refs/heads/master@{#440276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/devtools/devtools_window.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
einbinder
ptal
3 years, 12 months ago (2016-12-21 22:34:04 UTC) #2
caseq
+dgozman for OWNERS, I'm not an owner there. lgtm
3 years, 12 months ago (2016-12-21 22:46:30 UTC) #6
dgozman
lgtm
3 years, 12 months ago (2016-12-22 00:00:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594163002/1
3 years, 12 months ago (2016-12-22 00:14:14 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-22 00:19:12 UTC) #14
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 00:21:02 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2de169544dd69ffc7e31e87be92add166397ed12
Cr-Commit-Position: refs/heads/master@{#440276}

Powered by Google App Engine
This is Rietveld 408576698