Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: chrome/browser/devtools/devtools_window.cc

Issue 2594163002: DevTools: Add missing case to DoAction switch (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/devtools/devtools_window.h" 5 #include "chrome/browser/devtools/devtools_window.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/json/json_reader.h" 10 #include "base/json/json_reader.h"
(...skipping 1304 matching lines...) Expand 10 before | Expand all | Expand 10 after
1315 browser->window() : NULL; 1315 browser->window() : NULL;
1316 } 1316 }
1317 1317
1318 void DevToolsWindow::DoAction(const DevToolsToggleAction& action) { 1318 void DevToolsWindow::DoAction(const DevToolsToggleAction& action) {
1319 switch (action.type()) { 1319 switch (action.type()) {
1320 case DevToolsToggleAction::kInspect: 1320 case DevToolsToggleAction::kInspect:
1321 bindings_->CallClientFunction("DevToolsAPI.enterInspectElementMode", NULL, 1321 bindings_->CallClientFunction("DevToolsAPI.enterInspectElementMode", NULL,
1322 NULL, NULL); 1322 NULL, NULL);
1323 break; 1323 break;
1324 1324
1325 case DevToolsToggleAction::kShowElementsPanel:
1325 case DevToolsToggleAction::kShowConsolePanel: 1326 case DevToolsToggleAction::kShowConsolePanel:
1326 case DevToolsToggleAction::kShow: 1327 case DevToolsToggleAction::kShow:
1327 case DevToolsToggleAction::kToggle: 1328 case DevToolsToggleAction::kToggle:
1328 // Do nothing. 1329 // Do nothing.
1329 break; 1330 break;
1330 1331
1331 case DevToolsToggleAction::kReveal: { 1332 case DevToolsToggleAction::kReveal: {
1332 const DevToolsToggleAction::RevealParams* params = 1333 const DevToolsToggleAction::RevealParams* params =
1333 action.params(); 1334 action.params();
1334 CHECK(params); 1335 CHECK(params);
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
1390 bool DevToolsWindow::ReloadInspectedWebContents(bool bypass_cache) { 1391 bool DevToolsWindow::ReloadInspectedWebContents(bool bypass_cache) {
1391 // Only route reload via front-end if the agent is attached. 1392 // Only route reload via front-end if the agent is attached.
1392 WebContents* wc = GetInspectedWebContents(); 1393 WebContents* wc = GetInspectedWebContents();
1393 if (!wc || wc->GetCrashedStatus() != base::TERMINATION_STATUS_STILL_RUNNING) 1394 if (!wc || wc->GetCrashedStatus() != base::TERMINATION_STATUS_STILL_RUNNING)
1394 return false; 1395 return false;
1395 base::FundamentalValue bypass_cache_value(bypass_cache); 1396 base::FundamentalValue bypass_cache_value(bypass_cache);
1396 bindings_->CallClientFunction("DevToolsAPI.reloadInspectedPage", 1397 bindings_->CallClientFunction("DevToolsAPI.reloadInspectedPage",
1397 &bypass_cache_value, nullptr, nullptr); 1398 &bypass_cache_value, nullptr, nullptr);
1398 return true; 1399 return true;
1399 } 1400 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698