Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2594053002: [Schema Compiler] Remove cpp_util.PadForGenerics() (Closed)

Created:
4 years ago by Devlin
Modified:
4 years ago
Reviewers:
lazyboy
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Schema Compiler] Remove cpp_util.PadForGenerics() Way back when, compilers couldn't handle std::vector<std::unique_ptr<T>>, because they interpreted the double >> as a stream operator. They've gotten smarter, and now this works. Remove the PadForGenerics() method that was neccessary to add the space between > >. BUG=None Committed: https://crrev.com/81a0e72b623acb1710b279d072ba0272ad8234bf Cr-Commit-Position: refs/heads/master@{#440205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M tools/json_schema_compiler/cc_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/json_schema_compiler/cpp_type_generator.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/cpp_util.py View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/json_schema_compiler/h_generator.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Devlin
4 years ago (2016-12-21 19:25:08 UTC) #3
lazyboy
cool, lgtm.
4 years ago (2016-12-21 19:55:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594053002/1
4 years ago (2016-12-21 20:18:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 20:39:02 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-21 20:41:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81a0e72b623acb1710b279d072ba0272ad8234bf
Cr-Commit-Position: refs/heads/master@{#440205}

Powered by Google App Engine
This is Rietveld 408576698