Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: tools/json_schema_compiler/cpp_type_generator.py

Issue 2594053002: [Schema Compiler] Remove cpp_util.PadForGenerics() (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/json_schema_compiler/cc_generator.py ('k') | tools/json_schema_compiler/cpp_util.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/json_schema_compiler/cpp_type_generator.py
diff --git a/tools/json_schema_compiler/cpp_type_generator.py b/tools/json_schema_compiler/cpp_type_generator.py
index 269a99572c1453a789597dbbcf6b0b5dae01b79b..504016ceaad42587e8907d2ca6aea347875acaea 100644
--- a/tools/json_schema_compiler/cpp_type_generator.py
+++ b/tools/json_schema_compiler/cpp_type_generator.py
@@ -110,7 +110,7 @@ class CppTypeGenerator(object):
cpp_type = 'base::DictionaryValue'
elif type_.property_type == PropertyType.ARRAY:
item_cpp_type = self.GetCppType(type_.item_type, is_in_container=True)
- cpp_type = 'std::vector<%s>' % cpp_util.PadForGenerics(item_cpp_type)
+ cpp_type = 'std::vector<%s>' % item_cpp_type
elif type_.property_type == PropertyType.BINARY:
cpp_type = 'std::vector<char>'
else:
@@ -125,7 +125,7 @@ class CppTypeGenerator(object):
# Wrap ptrs and base::Values in containers (which aren't movable) in
# scoped_ptrs.
if is_ptr or (is_in_container and is_base_value):
- cpp_type = 'std::unique_ptr<%s>' % cpp_util.PadForGenerics(cpp_type)
+ cpp_type = 'std::unique_ptr<%s>' % cpp_type
return cpp_type
« no previous file with comments | « tools/json_schema_compiler/cc_generator.py ('k') | tools/json_schema_compiler/cpp_util.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698