Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2594013004: Suppress symbol import warning from linker when building cctest.exe (Closed)

Created:
4 years ago by Wez
Modified:
4 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Suppress symbol import warning from linker when building cctest.exe Ignoring this linker warning will enable Chromium builds to start treating all linker warnings as errors in Windows builds. BUG=676417, 659007 Review-Url: https://codereview.chromium.org/2594013004 Cr-Commit-Position: refs/heads/master@{#41931} Committed: https://chromium.googlesource.com/v8/v8/+/b344f930c8b39296ff5a38b79b47c5d35cc5648c

Patch Set 1 #

Patch Set 2 : Fix conditional #

Patch Set 3 : Correct diff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M test/cctest/BUILD.gn View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Wez
PTAL. This just suppresses the linker warning so we can enable treating warnings as errors; ...
4 years ago (2016-12-21 21:40:04 UTC) #2
Jarin
lgtm (rubberstamp).
4 years ago (2016-12-22 18:55:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594013004/20001
4 years ago (2016-12-22 19:01:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594013004/40001
4 years ago (2016-12-22 19:08:01 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-22 19:33:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/b344f930c8b39296ff5a38b79b47c5d35cc...

Powered by Google App Engine
This is Rietveld 408576698