Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: test/cctest/BUILD.gn

Issue 2594013004: Suppress symbol import warning from linker when building cctest.exe (Closed)
Patch Set: Correct diff Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/BUILD.gn
diff --git a/test/cctest/BUILD.gn b/test/cctest/BUILD.gn
index a90ff3c06306581e88dcc7f15366c9d74d2d1a11..54e733c2dced3b4aa4fb293c043785e6d309d767 100644
--- a/test/cctest/BUILD.gn
+++ b/test/cctest/BUILD.gn
@@ -358,6 +358,11 @@ v8_executable("cctest") {
cflags = []
ldflags = []
+ # crbug.com/676417: Suppress symbol import warning from linker.
+ if (is_win && is_component_build) {
+ ldflags = [ "/ignore:4217" ]
+ }
+
if (v8_current_cpu == "ppc" || v8_current_cpu == "ppc64" ||
v8_current_cpu == "arm" || v8_current_cpu == "arm64" ||
v8_current_cpu == "s390" || v8_current_cpu == "s390x" ||
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698