Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2593903002: [android] Use contextlib_ext.Optional for conditional context managers. (Closed)

Created:
4 years ago by jbudorick
Modified:
4 years ago
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[android] Use contextlib_ext.Optional for conditional context managers. Scripts in //build/android have been using hand-rolled workarounds for conditional context managers in the past. This switches them to a new implementation I added to catapult in https://codereview.chromium.org/2585763004/ Committed: https://crrev.com/8bfc633a1029b75e665fefe7d01a7b41102212e4 Cr-Commit-Position: refs/heads/master@{#440103}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -26 lines) Patch
M build/android/PRESUBMIT.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/__init__.py View 1 1 chunk +6 lines, -0 lines 0 comments Download
M build/android/pylib/local/device/local_device_perf_test_run.py View 1 3 chunks +4 lines, -12 lines 0 comments Download
M build/android/test_runner.py View 1 2 chunks +12 lines, -14 lines 0 comments Download
M build/android/test_runner.pydeps View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
jbudorick
4 years ago (2016-12-21 01:50:41 UTC) #3
rnephew (Reviews Here)
On 2016/12/21 01:50:41, jbudorick wrote: lgtm
4 years ago (2016-12-21 06:49:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593903002/1
4 years ago (2016-12-21 13:47:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/126617) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-21 13:49:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593903002/20001
4 years ago (2016-12-21 14:06:10 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-21 15:18:41 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8bfc633a1029b75e665fefe7d01a7b41102212e4 Cr-Commit-Position: refs/heads/master@{#440103}
4 years ago (2016-12-21 15:23:08 UTC) #16
rnephew (Reviews Here)
4 years ago (2016-12-21 16:00:56 UTC) #17
Message was sent while issue was closed.
Oh look, a comment I forgot to submit with the lgtm message.

https://codereview.chromium.org/2593903002/diff/1/build/android/pylib/__init_...
File build/android/pylib/__init__.py (right):

https://codereview.chromium.org/2593903002/diff/1/build/android/pylib/__init_...
build/android/pylib/__init__.py:8: _CATAPULT_PATH =
os.path.abspath(os.path.join(
I'm guessing this will hit some merge conflicts with my CL that just landed, so
you'll need to rebase.

Powered by Google App Engine
This is Rietveld 408576698