Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Side by Side Diff: build/android/PRESUBMIT.py

Issue 2593903002: [android] Use contextlib_ext.Optional for conditional context managers. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/android/pylib/__init__.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for android buildbot. 5 """Presubmit script for android buildbot.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8 details on the presubmit API built into depot_tools. 8 details on the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 14 matching lines...) Expand all
25 output.extend(input_api.canned_checks.RunPylint( 25 output.extend(input_api.canned_checks.RunPylint(
26 input_api, 26 input_api,
27 output_api, 27 output_api,
28 pylintrc='pylintrc', 28 pylintrc='pylintrc',
29 black_list=build_pys, 29 black_list=build_pys,
30 extra_paths_list=[ 30 extra_paths_list=[
31 J(), 31 J(),
32 J('gyp'), 32 J('gyp'),
33 J('buildbot'), 33 J('buildbot'),
34 J('..', '..', 'third_party', 'catapult', 'common', 'py_trace_event'), 34 J('..', '..', 'third_party', 'catapult', 'common', 'py_trace_event'),
35 J('..', '..', 'third_party', 'catapult', 'common', 'py_utils'),
35 J('..', '..', 'third_party', 'catapult', 'devil'), 36 J('..', '..', 'third_party', 'catapult', 'devil'),
36 J('..', '..', 'third_party', 'catapult', 'tracing') 37 J('..', '..', 'third_party', 'catapult', 'tracing')
37 ])) 38 ]))
38 output.extend(input_api.canned_checks.RunPylint( 39 output.extend(input_api.canned_checks.RunPylint(
39 input_api, 40 input_api,
40 output_api, 41 output_api,
41 white_list=build_pys, 42 white_list=build_pys,
42 extra_paths_list=[J('gyp'), J('gn')])) 43 extra_paths_list=[J('gyp'), J('gn')]))
43 44
44 # Disabled due to http://crbug.com/410936 45 # Disabled due to http://crbug.com/410936
(...skipping 27 matching lines...) Expand all
72 73
73 return output 74 return output
74 75
75 76
76 def CheckChangeOnUpload(input_api, output_api): 77 def CheckChangeOnUpload(input_api, output_api):
77 return CommonChecks(input_api, output_api) 78 return CommonChecks(input_api, output_api)
78 79
79 80
80 def CheckChangeOnCommit(input_api, output_api): 81 def CheckChangeOnCommit(input_api, output_api):
81 return CommonChecks(input_api, output_api) 82 return CommonChecks(input_api, output_api)
OLDNEW
« no previous file with comments | « no previous file | build/android/pylib/__init__.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698