Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2593853002: Remove unnecessary wrapper on DomHighResTimestamp, and clamp resolution to 1 millisecond (Closed)

Created:
4 years ago by panicker
Modified:
4 years ago
Reviewers:
haraken, skobes
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

- Remove incorrect wrapper on DomHighResTimestamp as it's already in milliseconds - Clamp resolution of timing to 1 millisecond BUG=671727 Committed: https://crrev.com/0a41be818b1ae20f9ff14f828184efc2ddf29448 Cr-Commit-Position: refs/heads/master@{#439989}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address format nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M third_party/WebKit/LayoutTests/fast/performance/longtasktiming.html View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.cpp View 2 chunks +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp View 1 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
panicker
Kentaro, Steve - mind reviewing this small CL?
4 years ago (2016-12-20 23:40:33 UTC) #4
skobes
lgtm w/ nit https://codereview.chromium.org/2593853002/diff/1/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp File third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp (right): https://codereview.chromium.org/2593853002/diff/1/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp#newcode17 third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp:17: } Add a blank line above ...
4 years ago (2016-12-20 23:48:38 UTC) #5
haraken
LGTM
4 years ago (2016-12-20 23:56:57 UTC) #6
panicker
https://codereview.chromium.org/2593853002/diff/1/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp File third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp (right): https://codereview.chromium.org/2593853002/diff/1/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp#newcode17 third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp:17: } On 2016/12/20 23:48:38, skobes wrote: > Add a ...
4 years ago (2016-12-21 00:10:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593853002/20001
4 years ago (2016-12-21 02:56:30 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-21 03:03:17 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-21 03:04:59 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a41be818b1ae20f9ff14f828184efc2ddf29448
Cr-Commit-Position: refs/heads/master@{#439989}

Powered by Google App Engine
This is Rietveld 408576698