Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp

Issue 2593853002: Remove unnecessary wrapper on DomHighResTimestamp, and clamp resolution to 1 millisecond (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/timing/PerformanceBase.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/timing/PerformanceLongTaskTiming.h" 5 #include "core/timing/PerformanceLongTaskTiming.h"
6 6
7 #include "core/frame/DOMWindow.h" 7 #include "core/frame/DOMWindow.h"
8 8
9 namespace blink { 9 namespace blink {
10 10
11 namespace {
12
13 double clampToMillisecond(double timeInMillis) {
14 // Long task times are clamped to 1 millisecond for security.
15 return floor(timeInMillis);
16 }
17 }
skobes 2016/12/20 23:48:38 Add a blank line above this one, and a comment lik
panicker 2016/12/21 00:10:08 Done.
18
11 PerformanceLongTaskTiming::PerformanceLongTaskTiming(double startTime, 19 PerformanceLongTaskTiming::PerformanceLongTaskTiming(double startTime,
12 double endTime, 20 double endTime,
13 String name, 21 String name,
14 String culpritFrameSrc, 22 String culpritFrameSrc,
15 String culpritFrameId, 23 String culpritFrameId,
16 String culpritFrameName) 24 String culpritFrameName)
17 : PerformanceEntry(name, "longtask", startTime, endTime), 25 : PerformanceEntry(name,
26 "longtask",
27 clampToMillisecond(startTime),
28 clampToMillisecond(endTime)),
18 m_culpritFrameSrc(culpritFrameSrc), 29 m_culpritFrameSrc(culpritFrameSrc),
19 m_culpritFrameId(culpritFrameId), 30 m_culpritFrameId(culpritFrameId),
20 m_culpritFrameName(culpritFrameName) {} 31 m_culpritFrameName(culpritFrameName) {}
21 32
22 PerformanceLongTaskTiming::~PerformanceLongTaskTiming() {} 33 PerformanceLongTaskTiming::~PerformanceLongTaskTiming() {}
23 34
24 String PerformanceLongTaskTiming::culpritFrameSrc() const { 35 String PerformanceLongTaskTiming::culpritFrameSrc() const {
25 return m_culpritFrameSrc; 36 return m_culpritFrameSrc;
26 } 37 }
27 38
28 String PerformanceLongTaskTiming::culpritFrameId() const { 39 String PerformanceLongTaskTiming::culpritFrameId() const {
29 return m_culpritFrameId; 40 return m_culpritFrameId;
30 } 41 }
31 42
32 String PerformanceLongTaskTiming::culpritFrameName() const { 43 String PerformanceLongTaskTiming::culpritFrameName() const {
33 return m_culpritFrameName; 44 return m_culpritFrameName;
34 } 45 }
35 46
36 DEFINE_TRACE(PerformanceLongTaskTiming) { 47 DEFINE_TRACE(PerformanceLongTaskTiming) {
37 PerformanceEntry::trace(visitor); 48 PerformanceEntry::trace(visitor);
38 } 49 }
39 50
40 } // namespace blink 51 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/timing/PerformanceBase.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698