Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2593603002: Fix non-virtual destructor in DelegatedFrameHostClient (Closed)

Created:
4 years ago by altimin
Modified:
4 years ago
CC:
chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, miu+watch_chromium.org, piman+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix non-virtual destructor in DelegatedFrameHostClient Committed: https://crrev.com/d0059913d4bbda3f638ae3a4212b22f4a78dbfde Cr-Commit-Position: refs/heads/master@{#439791}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/browser/renderer_host/delegated_frame_host.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host_client_aura.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
altimin
PTAL
4 years ago (2016-12-20 13:02:10 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years ago (2016-12-20 13:40:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593603002/1
4 years ago (2016-12-20 13:51:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 13:56:03 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-20 13:57:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0059913d4bbda3f638ae3a4212b22f4a78dbfde
Cr-Commit-Position: refs/heads/master@{#439791}

Powered by Google App Engine
This is Rietveld 408576698