Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Side by Side Diff: content/browser/renderer_host/delegated_frame_host.h

Issue 2593603002: Fix non-virtual destructor in DelegatedFrameHostClient (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/delegated_frame_host_client_aura.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_DELEGATED_FRAME_HOST_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_DELEGATED_FRAME_HOST_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_DELEGATED_FRAME_HOST_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_DELEGATED_FRAME_HOST_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 46
47 class DelegatedFrameHost; 47 class DelegatedFrameHost;
48 class RenderWidgetHostViewFrameSubscriber; 48 class RenderWidgetHostViewFrameSubscriber;
49 class ResizeLock; 49 class ResizeLock;
50 50
51 // The DelegatedFrameHostClient is the interface from the DelegatedFrameHost, 51 // The DelegatedFrameHostClient is the interface from the DelegatedFrameHost,
52 // which manages delegated frames, and the ui::Compositor being used to 52 // which manages delegated frames, and the ui::Compositor being used to
53 // display them. 53 // display them.
54 class CONTENT_EXPORT DelegatedFrameHostClient { 54 class CONTENT_EXPORT DelegatedFrameHostClient {
55 public: 55 public:
56 virtual ~DelegatedFrameHostClient() {}
57
56 virtual ui::Layer* DelegatedFrameHostGetLayer() const = 0; 58 virtual ui::Layer* DelegatedFrameHostGetLayer() const = 0;
57 virtual bool DelegatedFrameHostIsVisible() const = 0; 59 virtual bool DelegatedFrameHostIsVisible() const = 0;
58 60
59 // Returns the color that the resize gutters should be drawn with. Takes the 61 // Returns the color that the resize gutters should be drawn with. Takes the
60 // suggested color from the current page background. 62 // suggested color from the current page background.
61 virtual SkColor DelegatedFrameHostGetGutterColor(SkColor color) const = 0; 63 virtual SkColor DelegatedFrameHostGetGutterColor(SkColor color) const = 0;
62 virtual gfx::Size DelegatedFrameHostDesiredSizeInDIP() const = 0; 64 virtual gfx::Size DelegatedFrameHostDesiredSizeInDIP() const = 0;
63 65
64 virtual bool DelegatedFrameCanCreateResizeLock() const = 0; 66 virtual bool DelegatedFrameCanCreateResizeLock() const = 0;
65 virtual std::unique_ptr<ResizeLock> DelegatedFrameHostCreateResizeLock( 67 virtual std::unique_ptr<ResizeLock> DelegatedFrameHostCreateResizeLock(
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
330 // YUV readback pipeline. 332 // YUV readback pipeline.
331 std::unique_ptr<display_compositor::ReadbackYUVInterface> 333 std::unique_ptr<display_compositor::ReadbackYUVInterface>
332 yuv_readback_pipeline_; 334 yuv_readback_pipeline_;
333 335
334 std::unique_ptr<DelegatedFrameEvictor> delegated_frame_evictor_; 336 std::unique_ptr<DelegatedFrameEvictor> delegated_frame_evictor_;
335 }; 337 };
336 338
337 } // namespace content 339 } // namespace content
338 340
339 #endif // CONTENT_BROWSER_RENDERER_HOST_DELEGATED_FRAME_HOST_H_ 341 #endif // CONTENT_BROWSER_RENDERER_HOST_DELEGATED_FRAME_HOST_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/renderer_host/delegated_frame_host_client_aura.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698