Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2593483002: [ia32] Optimize index calculation for certain checked load/stores. (Closed)

Created:
4 years ago by shiyu.zhang
Modified:
3 years, 10 months ago
CC:
Pan, tianyou.li
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ia32] Optimize index calculation for certain checked load/stores. It reduces the add operation for certain checked load/stores by pre-do the add in compiling phase. BUG= Review-Url: https://codereview.chromium.org/2593483002 Cr-Commit-Position: refs/heads/master@{#43128} Committed: https://chromium.googlesource.com/v8/v8/+/d401543f84a0b9fa210a8d3c4330bbfe0f8788f4

Patch Set 1 #

Patch Set 2 : Fix asm-wasm regression #

Patch Set 3 : Rebase #

Patch Set 4 : Don't apply optimization for asm-wasm #

Patch Set 5 : Apply optimization for asw-wasm #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+463 lines, -58 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 1 2 3 4 5 6 3 chunks +415 lines, -58 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 2 3 4 5 6 2 chunks +48 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
shiyu.zhang
This patch fixed the regressions in https://bugs.chromium.org/p/chromium/issues/detail?id=673861. What's more, it applied the optimization for certain ...
4 years ago (2016-12-21 06:45:48 UTC) #5
shiyu.zhang
@Benedikt Meurer, PTAL
4 years ago (2016-12-23 03:39:59 UTC) #6
danno
3 years, 11 months ago (2017-01-19 15:47:50 UTC) #8
bradnelson
lgtm
3 years, 10 months ago (2017-02-12 08:16:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593483002/160001
3 years, 10 months ago (2017-02-12 08:16:42 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/34541)
3 years, 10 months ago (2017-02-12 08:19:32 UTC) #14
bradn
bmeurer, will need your OWNERS blessing too.
3 years, 10 months ago (2017-02-12 08:34:46 UTC) #16
Benedikt Meurer
On 2017/02/12 08:34:46, bradn wrote: > bmeurer, will need your OWNERS blessing too. LGTM (rubber ...
3 years, 10 months ago (2017-02-12 10:52:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593483002/160001
3 years, 10 months ago (2017-02-12 16:21:01 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-02-12 16:24:26 UTC) #22
Message was sent while issue was closed.
Committed patchset #7 (id:160001) as
https://chromium.googlesource.com/v8/v8/+/d401543f84a0b9fa210a8d3c4330bbfe0f8...

Powered by Google App Engine
This is Rietveld 408576698