Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2593443002: [ARM] Add fp version of vceq to assembler, disassembler, and simulator. (Closed)

Created:
4 years ago by bbudge
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM] Add fp version of vceq to assembler, disassembler, and simulator. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2593443002 Cr-Commit-Position: refs/heads/master@{#41859} Committed: https://chromium.googlesource.com/v8/v8/+/e54e2dd9163b8f093967d28af667114b9948d523

Patch Set 1 #

Patch Set 2 : Add missing UNIMPLEMENTED(). #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
M src/arm/assembler-arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/arm/disasm-arm.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 2 chunks +17 lines, -0 lines 1 comment Download
M test/cctest/test-assembler-arm.cc View 3 chunks +9 lines, -1 line 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
bbudge
https://codereview.chromium.org/2593443002/diff/20001/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): https://codereview.chromium.org/2593443002/diff/20001/src/arm/simulator-arm.cc#newcode4514 src/arm/simulator-arm.cc:4514: UNIMPLEMENTED(); We need this in case no case 5 ...
4 years ago (2016-12-20 01:16:58 UTC) #4
Rodolph Perfetta
lgtm
4 years ago (2016-12-20 11:24:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593443002/20001
4 years ago (2016-12-20 13:05:02 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-20 13:07:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e54e2dd9163b8f093967d28af667114b994...

Powered by Google App Engine
This is Rietveld 408576698