Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Issue 2593273003: DevTools: Do not reset timeline recoring options on basic/advanced switch. (Closed)

Created:
4 years ago by alph
Modified:
3 years, 12 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Do not reset timeline recoring options on basic/advanced switch. Committed: https://crrev.com/8f4f77835fe30ddf1d941904fa8ac6326d612f5e Cr-Commit-Position: refs/heads/master@{#440555}

Patch Set 1 #

Patch Set 2 : update tests #

Patch Set 3 : more tests #

Messages

Total messages: 19 (11 generated)
alph
4 years ago (2016-12-22 00:14:23 UTC) #2
pfeldman
lgtm
3 years, 12 months ago (2016-12-22 17:43:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593273003/1
3 years, 12 months ago (2016-12-22 17:46:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/361674)
3 years, 12 months ago (2016-12-22 19:08:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593273003/20001
3 years, 12 months ago (2016-12-22 21:34:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593273003/40001
3 years, 12 months ago (2016-12-22 23:00:51 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 12 months ago (2016-12-23 00:23:46 UTC) #17
commit-bot: I haz the power
3 years, 12 months ago (2016-12-23 00:26:13 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8f4f77835fe30ddf1d941904fa8ac6326d612f5e
Cr-Commit-Position: refs/heads/master@{#440555}

Powered by Google App Engine
This is Rietveld 408576698