third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js - Issue 2593273003: DevTools: Do not reset timeline recoring options on basic/advanced switch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

Issue 2593273003: DevTools: Do not reset timeline recoring options on basic/advanced switch. (Closed)

Patch Set: more tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-time/timeline-time.html ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

index 80358bbd8b5c63b556c01a938f2051ba4624eb94..d6769e73213c4285bf08aaa157aebc1303441fbd 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

@@ -24,7 +24,7 @@ Timeline.TimelineController = class {

}

/**

- * @param {!Timeline.TimelineController.CaptureOptions} options

+ * @param {!Timeline.TimelineController.RecordingOptions} options

* @param {!Array<!Extensions.ExtensionTraceProvider>} providers

startRecording(options, providers) {

@@ -278,10 +278,11 @@ Timeline.TimelineController = class {

}

};

-/** @typedef {!{

- * enableJSSampling: (boolean|undefined),

- * capturePictures: (boolean|undefined),

- * captureFilmStrip: (boolean|undefined)

- * }}

+/**

+ * @typedef {!{

+ * enableJSSampling: (boolean|undefined),

+ * capturePictures: (boolean|undefined),

+ * captureFilmStrip: (boolean|undefined)

+ * }}

-Timeline.TimelineController.CaptureOptions;

+Timeline.TimelineController.RecordingOptions;