Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2593243002: [promises] Set correct method on Promise.reject TypeError (Closed)

Created:
4 years ago by gsathya
Modified:
4 years ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] Set correct method on Promise.reject TypeError R=adamk@chromium.org Review-Url: https://codereview.chromium.org/2593243002 Cr-Commit-Position: refs/heads/master@{#41905} Committed: https://chromium.googlesource.com/v8/v8/+/c8ce0cf99eea5aedc45ca899fcb5d1c7764c2cb8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/js/promise.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
gsathya
4 years ago (2016-12-21 23:19:40 UTC) #3
adamk
lgtm
4 years ago (2016-12-21 23:29:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593243002/1
4 years ago (2016-12-21 23:51:04 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-21 23:52:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c8ce0cf99eea5aedc45ca899fcb5d1c7764...

Powered by Google App Engine
This is Rietveld 408576698