src/js/promise.js - Issue 2593243002: [promises] Set correct method on Promise.reject TypeError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/promise.js

Issue 2593243002: [promises] Set correct method on Promise.reject TypeError (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/js/promise.js

diff --git a/src/js/promise.js b/src/js/promise.js

index 9bf378025f48504f8e25e65923e5344846138391..eb63c280a181649e52877550c4e03bc43098ab67 100644

--- a/src/js/promise.js

+++ b/src/js/promise.js

@@ -126,7 +126,7 @@ function NewPromiseCapability(C, debugEvent) {

// Promise.reject ( x )

function PromiseReject(r) {

if (!IS_RECEIVER(this)) {

- throw %make_type_error(kCalledOnNonObject, PromiseResolve);

+ throw %make_type_error(kCalledOnNonObject, PromiseReject);

}

if (this === GlobalPromise) {

// Optimized case, avoid extra closure.

« no previous file with comments | « no previous file | no next file » | no next file with comments »