Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 2593033002: [ics]: Remove deprecated support for patching LoadICs and StoreICs (Closed)

Created:
4 years ago by danno
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ics]: Remove deprecated support for patching LoadICs and StoreICs Review-Url: https://codereview.chromium.org/2593033002 Cr-Commit-Position: refs/heads/master@{#41897} Committed: https://chromium.googlesource.com/v8/v8/+/455c244cbd69c6ab9ac35b2b8b61b2d737101863

Patch Set 1 #

Patch Set 2 : Remove more dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -240 lines) Patch
M src/code-stubs.h View 3 chunks +0 lines, -44 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 2 chunks +0 lines, -38 lines 0 comments Download
M src/counters.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/handler-compiler.cc View 2 chunks +5 lines, -17 lines 0 comments Download
M src/ic/ic.cc View 1 8 chunks +44 lines, -128 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
danno
ptal
4 years ago (2016-12-21 15:29:03 UTC) #4
Igor Sheludko
lgtm
4 years ago (2016-12-21 15:58:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593033002/20001
4 years ago (2016-12-21 16:00:19 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/455c244cbd69c6ab9ac35b2b8b61b2d737101863
4 years ago (2016-12-21 16:02:18 UTC) #12
Jakob Kummerow
4 years ago (2016-12-22 11:26:25 UTC) #13
Message was sent while issue was closed.
Ack. Cool!

Sorry I didn't get around to doing this cleanup.

Powered by Google App Engine
This is Rietveld 408576698