Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: src/code-stubs.h

Issue 2593033002: [ics]: Remove deprecated support for patching LoadICs and StoreICs (Closed)
Patch Set: Remove more dead code Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/code-stubs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 99256662dbe97c668429354a4460ec18751825fc..3134d4cee1a7bc45ef20b321dbff4bdc7cf783cb 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -68,8 +68,6 @@ class Node;
/* as part of the new IC system, ask */ \
/* ishell before doing anything */ \
V(LoadConstant) \
- V(LoadDictionaryElement) \
- V(LoadFastElement) \
V(LoadField) \
/* These should never be ported to TF */ \
/* because they are either used only by */ \
@@ -1926,15 +1924,6 @@ class StringCharAtGenerator {
};
-class LoadDictionaryElementStub : public HydrogenCodeStub {
- public:
- explicit LoadDictionaryElementStub(Isolate* isolate)
- : HydrogenCodeStub(isolate) {}
-
- DEFINE_CALL_INTERFACE_DESCRIPTOR(LoadWithVector);
- DEFINE_HYDROGEN_CODE_STUB(LoadDictionaryElement, HydrogenCodeStub);
-};
-
class LoadICTrampolineStub : public TurboFanCodeStub {
public:
explicit LoadICTrampolineStub(Isolate* isolate) : TurboFanCodeStub(isolate) {}
@@ -2239,39 +2228,6 @@ class StoreScriptContextFieldStub : public ScriptContextFieldStub {
DEFINE_TURBOFAN_CODE_STUB(StoreScriptContextField, ScriptContextFieldStub);
};
-
-class LoadFastElementStub : public HandlerStub {
- public:
- LoadFastElementStub(Isolate* isolate, bool is_js_array,
- ElementsKind elements_kind,
- bool convert_hole_to_undefined = false)
- : HandlerStub(isolate) {
- set_sub_minor_key(
- ElementsKindBits::encode(elements_kind) |
- IsJSArrayBits::encode(is_js_array) |
- CanConvertHoleToUndefined::encode(convert_hole_to_undefined));
- }
-
- Code::Kind kind() const override { return Code::KEYED_LOAD_IC; }
-
- bool is_js_array() const { return IsJSArrayBits::decode(sub_minor_key()); }
- bool convert_hole_to_undefined() const {
- return CanConvertHoleToUndefined::decode(sub_minor_key());
- }
-
- ElementsKind elements_kind() const {
- return ElementsKindBits::decode(sub_minor_key());
- }
-
- private:
- class ElementsKindBits: public BitField<ElementsKind, 0, 8> {};
- class IsJSArrayBits: public BitField<bool, 8, 1> {};
- class CanConvertHoleToUndefined : public BitField<bool, 9, 1> {};
-
- DEFINE_CALL_INTERFACE_DESCRIPTOR(LoadWithVector);
- DEFINE_HANDLER_CODE_STUB(LoadFastElement, HandlerStub);
-};
-
class StoreFastElementStub : public TurboFanCodeStub {
public:
StoreFastElementStub(Isolate* isolate, bool is_js_array,
« no previous file with comments | « no previous file | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698