Move session network stats from IO to UI

Move session network stats from IO to UI

This allows the removal of a nasty looking, crash causing, cast in
net_internals_ui.cc.

There is no real benefit of having this on the IO thread, so moving it
to the UI thread will get the same information to the user without a
crash.

BUG=674748
Committed: https://crrev.com/f0ef225bd59782ebf43f3cb7033dd46902c13a97
Cr-Commit-Position: refs/heads/master@{#440535}

[RyanSturm, 2016-12-20 19:29:31]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 19:30:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 20:57:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 20:57:54]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2016-12-20 22:09:05]

ryansturm@chromium.org changed reviewers:
+ mmenke@chromium.org, tbansal@chromium.org

[RyanSturm, 2016-12-20 22:09:05]

tbansal, mmenke: PTAL, thanks

[tbansal1, 2016-12-20 23:20:49]

https://codereview.chromium.org/2592783002/diff/1/chrome/browser/ui/webui/net...
File chrome/browser/ui/webui/net_internals/net_internals_ui.cc (right):

https://codereview.chromium.org/2592783002/diff/1/chrome/browser/ui/webui/net...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:571: void
NetInternalsMessageHandler::OnGetSessionNetworkStats(
Thanks, this is much better. Any idea why this code path was different than the
code path of OnGetHistoricNetworkStats()?

https://codereview.chromium.org/2592783002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
(right):

https://codereview.chromium.org/2592783002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc:669:
return test_context_->io_data()->actual_content_length();
Is it possible to get this from compression stats instead of from IO data?

https://codereview.chromium.org/2592783002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h
(right):

https://codereview.chromium.org/2592783002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h:259:
int64_t original_content_length_;
Is it possible to not define these variables in the test file, and call the
methods on the compression stats directly? It would be great if we did not have
to duplicate this.

[RyanSturm, 2016-12-21 00:01:55]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 00:02:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2016-12-21 00:10:19]

ryansturm@chromium.org changed reviewers:
+ xunjieli@chromium.org
- mmenke@chromium.org

[RyanSturm, 2016-12-21 00:10:20]

xunjieli: PTAL

-mmenke

https://codereview.chromium.org/2592783002/diff/1/chrome/browser/ui/webui/net...
File chrome/browser/ui/webui/net_internals/net_internals_ui.cc (right):

https://codereview.chromium.org/2592783002/diff/1/chrome/browser/ui/webui/net...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:571: void
NetInternalsMessageHandler::OnGetSessionNetworkStats(
On 2016/12/20 23:20:48, tbansal1 wrote:
> Thanks, this is much better. Any idea why this code path was different than
the
> code path of OnGetHistoricNetworkStats()?

At some point, compression_stats came about and the prefs moved to that, but the
session stats didn't.

https://codereview.chromium.org/2592783002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc
(right):

https://codereview.chromium.org/2592783002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc:669:
return test_context_->io_data()->actual_content_length();
On 2016/12/20 23:20:48, tbansal1 wrote:
> Is it possible to get this from compression stats instead of from IO data?

Done.

https://codereview.chromium.org/2592783002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h
(right):

https://codereview.chromium.org/2592783002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h:259:
int64_t original_content_length_;
On 2016/12/20 23:20:48, tbansal1 wrote:
> Is it possible to not define these variables in the test file, and call the
> methods on the compression stats directly? It would be great if we did not
have
> to duplicate this.

Done.

[tbansal1, 2016-12-21 00:18:22]

lgtm. Thanks for cleaning this up.

[xunjieli, 2016-12-21 00:26:16]

On 2016/12/21 00:10:20, Ryan Sturm wrote:
> xunjieli: PTAL

I am not an OWNER.

[RyanSturm, 2016-12-21 00:32:06]

ryansturm@chromium.org changed reviewers:
+ eroman@chromium.org
- xunjieli@chromium.org

[RyanSturm, 2016-12-21 00:32:07]

Thanks, xunjieli. I thought you were working on this as an OWNER.

eroman: PTAL

[commit-bot: I haz the power, 2016-12-21 01:16:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 01:16:22]

Dry run: This issue passed the CQ dry run.

[eroman, 2016-12-22 22:06:50]

net_internals_ui.cc LGTM

[RyanSturm, 2016-12-22 22:14:27]

The CQ bit was checked by ryansturm@chromium.org

[commit-bot: I haz the power, 2016-12-22 22:14:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 23:19:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482444867502190,
"parent_rev": "6da223f6881d4500a3d720d61dc80405b0eef4a4", "commit_rev":
"d7aebb6ba577ff6230c633bdbacca87bd1fcb772"}

[commit-bot: I haz the power, 2016-12-22 23:19:34]

Description was changed from

==========
Move session network stats from IO to UI

This allows the removal of a nasty looking, crash causing, cast in
net_internals_ui.cc.

There is no real benefit of having this on the IO thread, so moving it
to the UI thread will get the same information to the user without a
crash.

BUG=674748
==========

to

==========
Move session network stats from IO to UI

This allows the removal of a nasty looking, crash causing, cast in
net_internals_ui.cc.

There is no real benefit of having this on the IO thread, so moving it
to the UI thread will get the same information to the user without a
crash.

BUG=674748

Review-Url: https://codereview.chromium.org/2592783002
==========

[commit-bot: I haz the power, 2016-12-22 23:19:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-22 23:21:46]

Description was changed from

==========
Move session network stats from IO to UI

This allows the removal of a nasty looking, crash causing, cast in
net_internals_ui.cc.

There is no real benefit of having this on the IO thread, so moving it
to the UI thread will get the same information to the user without a
crash.

BUG=674748

Review-Url: https://codereview.chromium.org/2592783002
==========

to

==========
Move session network stats from IO to UI

This allows the removal of a nasty looking, crash causing, cast in
net_internals_ui.cc.

There is no real benefit of having this on the IO thread, so moving it
to the UI thread will get the same information to the user without a
crash.

BUG=674748

Committed: https://crrev.com/f0ef225bd59782ebf43f3cb7033dd46902c13a97
Cr-Commit-Position: refs/heads/master@{#440535}
==========

[commit-bot: I haz the power, 2016-12-22 23:21:47]

Patchset 2 (id:??) landed as
https://crrev.com/f0ef225bd59782ebf43f3cb7033dd46902c13a97
Cr-Commit-Position: refs/heads/master@{#440535}