Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

Issue 2592783002: Move session network stats from IO to UI (Closed)
Patch Set: tbansal nits Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
index 0a37807e2bb03372e4b2ba1aa9ffa91f3bc69dac..a23f1870c3085010e98d46ebc6e66bc00c14c9ea 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
@@ -11,7 +11,6 @@
#include "base/metrics/histogram_macros.h"
#include "base/strings/string_number_conversions.h"
#include "base/time/time.h"
-#include "base/values.h"
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h"
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h"
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator.h"
@@ -175,8 +174,6 @@ DataReductionProxyNetworkDelegate::DataReductionProxyNetworkDelegate(
DataReductionProxyRequestOptions* request_options,
const DataReductionProxyConfigurator* configurator)
: LayeredNetworkDelegate(std::move(network_delegate)),
- total_received_bytes_(0),
- total_original_received_bytes_(0),
data_reduction_proxy_config_(config),
data_reduction_proxy_bypass_stats_(nullptr),
data_reduction_proxy_request_options_(request_options),
@@ -199,18 +196,6 @@ void DataReductionProxyNetworkDelegate::InitIODataAndUMA(
data_reduction_proxy_bypass_stats_ = bypass_stats;
}
-std::unique_ptr<base::Value>
-DataReductionProxyNetworkDelegate::SessionNetworkStatsInfoToValue() const {
- DCHECK(thread_checker_.CalledOnValidThread());
- auto dict = base::MakeUnique<base::DictionaryValue>();
- // Use strings to avoid overflow. base::Value only supports 32-bit integers.
- dict->SetString("session_received_content_length",
- base::Int64ToString(total_received_bytes_));
- dict->SetString("session_original_content_length",
- base::Int64ToString(total_original_received_bytes_));
- return std::move(dict);
-}
-
void DataReductionProxyNetworkDelegate::OnBeforeURLRequestInternal(
net::URLRequest* request,
const net::CompletionCallback& callback,
@@ -424,8 +409,6 @@ void DataReductionProxyNetworkDelegate::AccumulateDataUsage(
data_used, original_size, data_reduction_proxy_io_data_->IsEnabled(),
request_type, data_use_group, mime_type);
}
- total_received_bytes_ += data_used;
- total_original_received_bytes_ += original_size;
}
void DataReductionProxyNetworkDelegate::RecordContentLength(

Powered by Google App Engine
This is Rietveld 408576698