Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: Source/core/frame/SmartClip.cpp

Issue 259263003: Fix to remove customised String over IPC for SmartClip (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: changed according to review comments by eseidel Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/SmartClip.cpp
diff --git a/Source/core/frame/SmartClip.cpp b/Source/core/frame/SmartClip.cpp
index 3a95095c06e4ef057ba19fe6b31f9962b2223556..c49f3032bdfe0334a2d4433019198c64558ae0a9 100644
--- a/Source/core/frame/SmartClip.cpp
+++ b/Source/core/frame/SmartClip.cpp
@@ -61,33 +61,14 @@ static Node* nodeInsideFrame(Node* node)
return 0;
}
-// FIXME: SmartClipData is eventually returned via
-// SLookSmartClip.DataExtractionListener:
-// http://img-developer.samsung.com/onlinedocs/sms/com/samsung/android/sdk/look/...
-// however the original author of this change chose to use a string-serialization
-// format (presumably to make IPC easy?).
-// If we're going to use this as a Pickle format, we should at least have the
-// read/write code in one place!
-String SmartClipData::toString()
+IntRect SmartClipData::rect() const
{
- if (!m_node)
- return emptyString();
-
- const UChar fieldSeparator = 0xFFFE;
- const UChar rowSeparator = 0xFFFF;
+ return m_rect;
+}
- StringBuilder result;
- result.append(String::number(m_rect.x()));
- result.append(fieldSeparator);
- result.append(String::number(m_rect.y()));
- result.append(fieldSeparator);
- result.append(String::number(m_rect.width()));
- result.append(fieldSeparator);
- result.append(String::number(m_rect.height()));
- result.append(fieldSeparator);
- result.append(m_string);
- result.append(rowSeparator);
- return result.toString();
+String SmartClipData::clipData() const
Inactive 2014/06/09 14:00:51 Could return a const String&.
AviD 2014/06/13 11:52:48 Done.
+{
+ return m_string;
}
SmartClip::SmartClip(PassRefPtr<LocalFrame> frame)

Powered by Google App Engine
This is Rietveld 408576698