Fix to remove customised String over IPC for SmartClip

Source/core/frame/SmartClip.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 43 matching lines @@
     return result;
 }
 
 static Node* nodeInsideFrame(Node* node)
 {
     if (node->isFrameOwnerElement())
         return toHTMLFrameOwnerElement(node)->contentDocument();
     return 0;
 }
 
-// FIXME: SmartClipData is eventually returned via
-// SLookSmartClip.DataExtractionListener:
-// http://img-developer.samsung.com/onlinedocs/sms/com/samsung/android/sdk/look/...
-// however the original author of this change chose to use a string-serialization
-// format (presumably to make IPC easy?).
-// If we're going to use this as a Pickle format, we should at least have the
-// read/write code in one place!
-String SmartClipData::toString()
+IntRect SmartClipData::rect() const
 {
-    if (!m_node)
-        return emptyString();
+    return m_rect;
+}
 
-    const UChar fieldSeparator = 0xFFFE;
-    const UChar rowSeparator = 0xFFFF;
-
-    StringBuilder result;
-    result.append(String::number(m_rect.x()));
-    result.append(fieldSeparator);
-    result.append(String::number(m_rect.y()));
-    result.append(fieldSeparator);
-    result.append(String::number(m_rect.width()));
-    result.append(fieldSeparator);
-    result.append(String::number(m_rect.height()));
-    result.append(fieldSeparator);
-    result.append(m_string);
-    result.append(rowSeparator);
-    return result.toString();
+String SmartClipData::clipData() const

[Inactive, 2014/06/09 14:00:51]

Could return a const String&.

[AviD, 2014/06/13 11:52:48]

Done.

+{
+    return m_string;
 }
 
 SmartClip::SmartClip(PassRefPtr<LocalFrame> frame)
     : m_frame(frame)
 {
 }
 
 SmartClipData SmartClip::dataForRect(const IntRect& cropRect)
 {
     IntRect resizedCropRect = applyScaleWithoutCollapsingToZero(cropRect, 1 / pageScaleFactor());
@@ skipping 186 matching lines @@
 
                 result.append(nodeValue);
             }
         }
     }
 
     return result.toString();
 }
 
 } // namespace WebCore