Source/web/WebViewImpl.h - Issue 259263003: Fix to remove customised String over IPC for SmartClip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.h

Issue 259263003: Fix to remove customised String over IPC for SmartClip (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: changed according to review comments by eseidel Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.h

diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h

index 6cfa048a782361068c85b95edc2b7099ede399c2..0d503637db38788a705ccb2541ac61accfe61938 100644

--- a/Source/web/WebViewImpl.h

+++ b/Source/web/WebViewImpl.h

@@ -246,7 +246,10 @@ public:

unsigned inactiveForegroundColor) OVERRIDE;

virtual void performCustomContextMenuAction(unsigned action) OVERRIDE;

virtual void showContextMenu() OVERRIDE;

+ // TODO(AviD):This should be removed when the chromium side patch lands

Inactive 2014/06/09 14:00:51 Please use FIXME and without attribution: http://d

AviD 2014/06/13 11:52:48 Done.

+ // http://codereview.chromium.org/260623004

virtual WebString getSmartClipData(WebRect) OVERRIDE;

+ virtual void getSmartClipData(WebRect, WebString*, WebRect*) OVERRIDE;

virtual void hidePopups() OVERRIDE;

virtual void addPageOverlay(WebPageOverlay*, int /* zOrder */) OVERRIDE;

virtual void removePageOverlay(WebPageOverlay*) OVERRIDE;

« Source/core/frame/SmartClip.cpp ('K') | « Source/core/frame/SmartClip.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | Source/web/tests/WebViewTest.cpp » ('J')