DevTools: Add Closure docs and clean up UISourceCode

DevTools: Add Closure docs and clean up UISourceCode

BUG=none

Committed: https://crrev.com/bc6fa35d85a5041c400f104ebed16ba92a0c6f64
Cr-Commit-Position: refs/heads/master@{#439665}

[einbinder, 2016-12-19 21:34:15]

einbinder@chromium.org changed reviewers:
+ lushnikov@chromium.org

[einbinder, 2016-12-19 21:34:16]

ptal

https://codereview.chromium.org/2592513002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html
(right):

https://codereview.chromium.org/2592513002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html:107:
uiSourceCode1._requestContentPromise = null;
There was a race condition before with _requestContentPromise.

https://codereview.chromium.org/2592513002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(left):

https://codereview.chromium.org/2592513002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:213: if
(this._content || this._contentLoaded)
Just return the same loading promise. Makes things simpler.

https://codereview.chromium.org/2592513002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:487:
_fireContentAvailable(content) {
This gets inlined.

https://codereview.chromium.org/2592513002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/2592513002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:70:
this._contentLoaded = false;
Make things explicit. Never undefined.

https://codereview.chromium.org/2592513002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:314:
this._requestContentPromise = Promise.resolve(/** @type {?string} */ (content));
Closure gets confused with {?string} and {string}.

https://codereview.chromium.org/2592513002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:403:
return /** @type {string} */ (this._workingCopy);
we know that workingCopyGetter is null, and it is dirty, so workingCopy must be
non-null.

https://codereview.chromium.org/2592513002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:428: */
Typing!

[lushnikov, 2016-12-19 23:32:13]

https://codereview.chromium.org/2592513002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/2592513002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:314:
this._requestContentPromise = Promise.resolve(/** @type {?string} */ (content));
let's clean the promise here to not do unnecessary work

[einbinder, 2016-12-19 23:48:49]

https://codereview.chromium.org/2592513002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/2592513002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:314:
this._requestContentPromise = Promise.resolve(/** @type {?string} */ (content));
On 2016/12/19 at 23:32:13, lushnikov wrote:
> let's clean the promise here to not do unnecessary work

Done.

[lushnikov, 2016-12-19 23:51:58]

lgtm

https://codereview.chromium.org/2592513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/2592513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:223: if
(!this._requestContentPromise) {
let's fast-return!

[einbinder, 2016-12-20 00:28:45]

https://codereview.chromium.org/2592513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/2592513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:223: if
(!this._requestContentPromise) {
On 2016/12/19 at 23:51:58, lushnikov wrote:
> let's fast-return!

Done.

[einbinder, 2016-12-20 00:28:49]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2016-12-20 00:28:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2592513002/#ps40001
(title: "Fast return")

[commit-bot: I haz the power, 2016-12-20 00:29:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 01:57:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482193729667940,
"parent_rev": "5a1668a3173c67ee68dcd68c56930a2f1d0e2b24", "commit_rev":
"8443c285dcafa64b9274f4e8cd2528f2abeb4d41"}

[commit-bot: I haz the power, 2016-12-20 01:58:13]

Description was changed from

==========
DevTools: Add Closure docs and clean up UISourceCode

BUG=none
==========

to

==========
DevTools: Add Closure docs and clean up UISourceCode

BUG=none

Review-Url: https://codereview.chromium.org/2592513002
==========

[commit-bot: I haz the power, 2016-12-20 01:58:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-20 02:01:25]

Description was changed from

==========
DevTools: Add Closure docs and clean up UISourceCode

BUG=none

Review-Url: https://codereview.chromium.org/2592513002
==========

to

==========
DevTools: Add Closure docs and clean up UISourceCode

BUG=none

Committed: https://crrev.com/bc6fa35d85a5041c400f104ebed16ba92a0c6f64
Cr-Commit-Position: refs/heads/master@{#439665}
==========

[commit-bot: I haz the power, 2016-12-20 02:01:26]

Patchset 3 (id:??) landed as
https://crrev.com/bc6fa35d85a5041c400f104ebed16ba92a0c6f64
Cr-Commit-Position: refs/heads/master@{#439665}