DevTools: Cache the original content on UISourceCode

DevTools: Cache the original content on UISourceCode

Previously, requestOriginalContent fetched the content from the
filesystem.
If the user saves changes to the file system, then it is no longer the
original content.

BUG=none

[einbinder, 2016-12-16 23:42:59]

einbinder@chromium.org changed reviewers:
+ lushnikov@chromium.org

[einbinder, 2016-12-16 23:43:00]

ptal

https://codereview.chromium.org/2588503002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html
(right):

https://codereview.chromium.org/2588503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html:41:
uiSourceCode.requestContent().then( () => {
We need to signal our intention to use this uiSourceCode by
uiSourceCode.requestContent(). Otherwise the original content won't have been
cached.

https://codereview.chromium.org/2588503002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/2588503002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:396:
return this._content || '';
This could have returned null before.

[lushnikov, 2016-12-17 00:10:51]

https://codereview.chromium.org/2588503002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/2588503002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:306:
this._setContent(content);
why do you want to link original content to the content?

Can we make requestOriginalContent() consistently return the same result over
time?

[einbinder, 2016-12-19 23:20:20]

einbinder@chromium.org changed reviewers:
- lushnikov@chromium.org

[einbinder, 2016-12-20 00:56:55]

einbinder@chromium.org changed reviewers:
+ lushnikov@chromium.org

[einbinder, 2016-12-20 00:56:55]

ptal

https://codereview.chromium.org/2588503002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/2588503002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:306:
this._setContent(content);
On 2016/12/17 at 00:10:51, lushnikov wrote:
> why do you want to link original content to the content?
> 
> Can we make requestOriginalContent() consistently return the same result over
time?

Yep. Done.

https://codereview.chromium.org/2588503002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html
(left):

https://codereview.chromium.org/2588503002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html:22: 
There was trailing whitespace in this file.

[lushnikov, 2016-12-20 01:05:23]

https://codereview.chromium.org/2588503002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/2588503002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:308:
this.requestOriginalContent().then(() => this._project.setFileContent(this,
content, function() {}));
this should be in filesystemworkspacebindings

[einbinder, 2016-12-20 03:10:34]

Moved the caching logic in the projects.

https://codereview.chromium.org/2588503002/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js
(left):

https://codereview.chromium.org/2588503002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js:299:
* @param {function(?string)} callback
The parameter in the callback was never used.

https://codereview.chromium.org/2588503002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js:303:
this._fileSystem.setFileContent(filePath, newContent, callback.bind(this, ''));
Bind the callback to this?! What is going on.