Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2592393003: Revert of Reland "[heap] Ensure progress when incrementally marking wrappers" (Closed)

Created:
3 years, 12 months ago by Michael Lippautz
Modified:
3 years, 12 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland "[heap] Ensure progress when incrementally marking wrappers" (patchset #8 id:140001 of https://codereview.chromium.org/2591383004/ ) Reason for revert: Breaks webkit-unit-tests. Investigating.. Original issue's description: > Reland "[heap] Ensure progress when incrementally marking wrappers" > > 1) Alternate between processing v8 and wrappers > 2) Once v8 is empty, try 3 rounds of finding the fixpoint between v8 and wrappers > 3) After that, finalize once v8 marking deque is empty again > > BUG= > > Review-Url: https://codereview.chromium.org/2591383004 > Cr-Commit-Position: refs/heads/master@{#41932} > Committed: https://chromium.googlesource.com/v8/v8/+/61a55548c50e01d84ed4aefa396324cbb4039b51 TBR=hpayer@chromium.org,ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2592393003 Cr-Commit-Position: refs/heads/master@{#41936} Committed: https://chromium.googlesource.com/v8/v8/+/833d2c4b05cef909a157da90a4ff6db27a09849a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -64 lines) Patch
M src/heap/embedder-tracing.h View 3 chunks +1 line, -12 lines 0 comments Download
M src/heap/embedder-tracing.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +9 lines, -11 lines 0 comments Download
M src/heap/incremental-marking.cc View 2 chunks +34 lines, -38 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Lippautz
Created Revert of Reland "[heap] Ensure progress when incrementally marking wrappers"
3 years, 12 months ago (2016-12-23 09:47:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2592393003/1
3 years, 12 months ago (2016-12-23 09:47:11 UTC) #3
commit-bot: I haz the power
3 years, 12 months ago (2016-12-23 09:47:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/833d2c4b05cef909a157da90a4ff6db27a0...

Powered by Google App Engine
This is Rietveld 408576698